Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade-to-latest-toolchain #4585

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

aoudiamoncef
Copy link
Contributor

@aoudiamoncef aoudiamoncef commented Dec 11, 2023

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

closes #4584

@aoudiamoncef aoudiamoncef changed the title Update addresses and public keys Upgrade-to-latest-toolchain Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (test_27_6_wip@a941a7c). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             test_27_6_wip    #4585   +/-   ##
================================================
  Coverage                 ?   71.78%           
================================================
  Files                    ?      291           
  Lines                    ?    51642           
  Branches                 ?        0           
================================================
  Hits                     ?    37069           
  Misses                   ?    14573           
  Partials                 ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aoudiamoncef aoudiamoncef force-pushed the feature/upgrade-to-latest-toolchain branch from 3293232 to 800221f Compare December 11, 2023 23:53
@aoudiamoncef aoudiamoncef merged commit 6efec44 into test_27_6_wip Dec 14, 2023
12 checks passed
@aoudiamoncef aoudiamoncef deleted the feature/upgrade-to-latest-toolchain branch December 14, 2023 10:49
damip added a commit that referenced this pull request Dec 15, 2023
* Update addresses and public keys

* Add more info to double staking protection's panic message

* fmt

* update version and genesis

* Update version and CI

* Update Cargo.lock

* add community charter

* Add serde json tests (#4579)

* chore: typo fix (#4589)

* Update to wasmer 4.2.4 (#4581)

Co-authored-by: sydhds <sydhds@gmail.com>

* typo fix

* typo fix

* typo fix

* typo fix

* typo fix

---------

Co-authored-by: Sydhds <sylvain.delhomme@gmail.com>
Co-authored-by: sydhds <sydhds@gmail.com>

* ci: add checksum + tested with ACT (#4590)

* Upgrade-to-latest-toolchain (#4585)

Co-authored-by: Leo-Besancon <lb@massa.net>

* Update massa-sc-runtime

Signed-off-by: Jean-François <jfm@laposte.net>

* Cargo update

* Remove compatibility layer in tracing (#4535)

* Add deferred_credits initial file for test

* Update Genesis and CI

* Push back Genesis

* Same

---------

Signed-off-by: Jean-François <jfm@laposte.net>
Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>
Co-authored-by: Moncef AOUDIA <ma@massa.net>
Co-authored-by: Ursulafe <152976968+Ursulafe@users.noreply.github.com>
Co-authored-by: Sydhds <sylvain.delhomme@gmail.com>
Co-authored-by: sydhds <sydhds@gmail.com>
Co-authored-by: Jean-François <jfm@laposte.net>
Leo-Besancon added a commit that referenced this pull request Dec 15, 2023
* Update addresses and public keys

* Add more info to double staking protection's panic message

* fmt

* update version and genesis

* Update version and CI

* Update Cargo.lock

* add community charter

* Add serde json tests (#4579)

* chore: typo fix (#4589)

* Update to wasmer 4.2.4 (#4581)

Co-authored-by: sydhds <sydhds@gmail.com>

* typo fix

* typo fix

* typo fix

* typo fix

* typo fix

---------

Co-authored-by: Sydhds <sylvain.delhomme@gmail.com>
Co-authored-by: sydhds <sydhds@gmail.com>

* ci: add checksum + tested with ACT (#4590)

* Upgrade-to-latest-toolchain (#4585)

Co-authored-by: Leo-Besancon <lb@massa.net>

* Update massa-sc-runtime

Signed-off-by: Jean-François <jfm@laposte.net>

* Cargo update

* Remove compatibility layer in tracing (#4535)

* Add deferred_credits initial file for test

* Update Genesis and CI

* Push back Genesis

* Same

---------

Signed-off-by: Jean-François <jfm@laposte.net>
Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>
Co-authored-by: Moncef AOUDIA <ma@massa.net>
Co-authored-by: Ursulafe <152976968+Ursulafe@users.noreply.github.com>
Co-authored-by: Sydhds <sylvain.delhomme@gmail.com>
Co-authored-by: sydhds <sydhds@gmail.com>
Co-authored-by: Jean-François <jfm@laposte.net>
sydhds added a commit that referenced this pull request Dec 20, 2023
* Update addresses and public keys

* Add more info to double staking protection's panic message

* fmt

* update version and genesis

* Update version and CI

* Update Cargo.lock

* add community charter

* Add serde json tests (#4579)

* chore: typo fix (#4589)

* Update to wasmer 4.2.4 (#4581)

Co-authored-by: sydhds <sydhds@gmail.com>

* typo fix

* typo fix

* typo fix

* typo fix

* typo fix

---------

Co-authored-by: Sydhds <sylvain.delhomme@gmail.com>
Co-authored-by: sydhds <sydhds@gmail.com>

* ci: add checksum + tested with ACT (#4590)

* Upgrade-to-latest-toolchain (#4585)

Co-authored-by: Leo-Besancon <lb@massa.net>

* Update massa-sc-runtime

Signed-off-by: Jean-François <jfm@laposte.net>

* Cargo update

* Remove compatibility layer in tracing (#4535)

* Add deferred_credits initial file for test

* Update Genesis and CI

* Push back Genesis

* Same

---------

Signed-off-by: Jean-François <jfm@laposte.net>
Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>
Co-authored-by: Moncef AOUDIA <ma@massa.net>
Co-authored-by: Ursulafe <152976968+Ursulafe@users.noreply.github.com>
Co-authored-by: Sydhds <sylvain.delhomme@gmail.com>
Co-authored-by: sydhds <sydhds@gmail.com>
Co-authored-by: Jean-François <jfm@laposte.net>
sydhds added a commit that referenced this pull request Dec 20, 2023
* Update addresses and public keys

* Add more info to double staking protection's panic message

* fmt

* update version and genesis

* Update version and CI

* Update Cargo.lock

* add community charter

* Add serde json tests (#4579)

* chore: typo fix (#4589)

* Update to wasmer 4.2.4 (#4581)

Co-authored-by: sydhds <sydhds@gmail.com>

* typo fix

* typo fix

* typo fix

* typo fix

* typo fix

---------

Co-authored-by: Sydhds <sylvain.delhomme@gmail.com>
Co-authored-by: sydhds <sydhds@gmail.com>

* ci: add checksum + tested with ACT (#4590)

* Upgrade-to-latest-toolchain (#4585)

Co-authored-by: Leo-Besancon <lb@massa.net>

* Update massa-sc-runtime

Signed-off-by: Jean-François <jfm@laposte.net>

* Cargo update

* Remove compatibility layer in tracing (#4535)

* Add deferred_credits initial file for test

* Update Genesis and CI

* Push back Genesis

* Same

---------

Signed-off-by: Jean-François <jfm@laposte.net>
Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>
Co-authored-by: Moncef AOUDIA <ma@massa.net>
Co-authored-by: Ursulafe <152976968+Ursulafe@users.noreply.github.com>
Co-authored-by: Sydhds <sylvain.delhomme@gmail.com>
Co-authored-by: sydhds <sydhds@gmail.com>
Co-authored-by: Jean-François <jfm@laposte.net>
github-merge-queue bot pushed a commit that referenced this pull request Dec 22, 2023
* Add initial chain id impl

* Add chain id to jsonrpc, grpc public & grpc private api

* Add massa-client features sandbox

* Add chain id SC unit test

* Fix unit test + add dummy gas costs

* Update massa-proto-rs dependency

* Update massa-sc-runtime dependency

* Add unit test allowing easy update of massa docs

* Use chain id through config instead of constants directly

* Use chain id everywhere (round 1) (#4594)

* Use chain id everywhere (round 1)

* Use chain id in massa client

---------

Co-authored-by: sydhds <sydhds@gmail.com>

* Remove confusing chain id

* Fix some unit tests

* Test 27 6 wip (#4582)

* Update addresses and public keys

* Add more info to double staking protection's panic message

* fmt

* update version and genesis

* Update version and CI

* Update Cargo.lock

* add community charter

* Add serde json tests (#4579)

* chore: typo fix (#4589)

* Update to wasmer 4.2.4 (#4581)

Co-authored-by: sydhds <sydhds@gmail.com>

* typo fix

* typo fix

* typo fix

* typo fix

* typo fix

---------

Co-authored-by: Sydhds <sylvain.delhomme@gmail.com>
Co-authored-by: sydhds <sydhds@gmail.com>

* ci: add checksum + tested with ACT (#4590)

* Upgrade-to-latest-toolchain (#4585)

Co-authored-by: Leo-Besancon <lb@massa.net>

* Update massa-sc-runtime

Signed-off-by: Jean-François <jfm@laposte.net>

* Cargo update

* Remove compatibility layer in tracing (#4535)

* Add deferred_credits initial file for test

* Update Genesis and CI

* Push back Genesis

* Same

---------

Signed-off-by: Jean-François <jfm@laposte.net>
Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>
Co-authored-by: Moncef AOUDIA <ma@massa.net>
Co-authored-by: Ursulafe <152976968+Ursulafe@users.noreply.github.com>
Co-authored-by: Sydhds <sylvain.delhomme@gmail.com>
Co-authored-by: sydhds <sydhds@gmail.com>
Co-authored-by: Jean-François <jfm@laposte.net>

* Add initial chain id impl

* Use chain id everywhere (round 1) (#4594)

* Use chain id everywhere (round 1)

* Use chain id in massa client

---------

Co-authored-by: sydhds <sydhds@gmail.com>

* Fix unit tests (final round)

* Minor fix

* Revert some nasty insert from bad rebase

* Auto gen chain id from VERSION

* Cargo clippy && fmt && doc pass

* Update massa-sc-runtime dependency

---------

Signed-off-by: Jean-François <jfm@laposte.net>
Co-authored-by: sydhds <sydhds@gmail.com>
Co-authored-by: Leo-Besancon <lb@massa.net>
Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>
Co-authored-by: Moncef AOUDIA <ma@massa.net>
Co-authored-by: Ursulafe <152976968+Ursulafe@users.noreply.github.com>
Co-authored-by: Jean-François <jfm@laposte.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants