-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: typo fix #4589
Merged
Merged
chore: typo fix #4589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leo-Besancon
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
damip
added a commit
that referenced
this pull request
Dec 15, 2023
* Update addresses and public keys * Add more info to double staking protection's panic message * fmt * update version and genesis * Update version and CI * Update Cargo.lock * add community charter * Add serde json tests (#4579) * chore: typo fix (#4589) * Update to wasmer 4.2.4 (#4581) Co-authored-by: sydhds <sydhds@gmail.com> * typo fix * typo fix * typo fix * typo fix * typo fix --------- Co-authored-by: Sydhds <sylvain.delhomme@gmail.com> Co-authored-by: sydhds <sydhds@gmail.com> * ci: add checksum + tested with ACT (#4590) * Upgrade-to-latest-toolchain (#4585) Co-authored-by: Leo-Besancon <lb@massa.net> * Update massa-sc-runtime Signed-off-by: Jean-François <jfm@laposte.net> * Cargo update * Remove compatibility layer in tracing (#4535) * Add deferred_credits initial file for test * Update Genesis and CI * Push back Genesis * Same --------- Signed-off-by: Jean-François <jfm@laposte.net> Co-authored-by: Damir Vodenicarevic <damipator@gmail.com> Co-authored-by: Moncef AOUDIA <ma@massa.net> Co-authored-by: Ursulafe <152976968+Ursulafe@users.noreply.github.com> Co-authored-by: Sydhds <sylvain.delhomme@gmail.com> Co-authored-by: sydhds <sydhds@gmail.com> Co-authored-by: Jean-François <jfm@laposte.net>
Leo-Besancon
added a commit
that referenced
this pull request
Dec 15, 2023
* Update addresses and public keys * Add more info to double staking protection's panic message * fmt * update version and genesis * Update version and CI * Update Cargo.lock * add community charter * Add serde json tests (#4579) * chore: typo fix (#4589) * Update to wasmer 4.2.4 (#4581) Co-authored-by: sydhds <sydhds@gmail.com> * typo fix * typo fix * typo fix * typo fix * typo fix --------- Co-authored-by: Sydhds <sylvain.delhomme@gmail.com> Co-authored-by: sydhds <sydhds@gmail.com> * ci: add checksum + tested with ACT (#4590) * Upgrade-to-latest-toolchain (#4585) Co-authored-by: Leo-Besancon <lb@massa.net> * Update massa-sc-runtime Signed-off-by: Jean-François <jfm@laposte.net> * Cargo update * Remove compatibility layer in tracing (#4535) * Add deferred_credits initial file for test * Update Genesis and CI * Push back Genesis * Same --------- Signed-off-by: Jean-François <jfm@laposte.net> Co-authored-by: Damir Vodenicarevic <damipator@gmail.com> Co-authored-by: Moncef AOUDIA <ma@massa.net> Co-authored-by: Ursulafe <152976968+Ursulafe@users.noreply.github.com> Co-authored-by: Sydhds <sylvain.delhomme@gmail.com> Co-authored-by: sydhds <sydhds@gmail.com> Co-authored-by: Jean-François <jfm@laposte.net>
sydhds
added a commit
that referenced
this pull request
Dec 20, 2023
* Update addresses and public keys * Add more info to double staking protection's panic message * fmt * update version and genesis * Update version and CI * Update Cargo.lock * add community charter * Add serde json tests (#4579) * chore: typo fix (#4589) * Update to wasmer 4.2.4 (#4581) Co-authored-by: sydhds <sydhds@gmail.com> * typo fix * typo fix * typo fix * typo fix * typo fix --------- Co-authored-by: Sydhds <sylvain.delhomme@gmail.com> Co-authored-by: sydhds <sydhds@gmail.com> * ci: add checksum + tested with ACT (#4590) * Upgrade-to-latest-toolchain (#4585) Co-authored-by: Leo-Besancon <lb@massa.net> * Update massa-sc-runtime Signed-off-by: Jean-François <jfm@laposte.net> * Cargo update * Remove compatibility layer in tracing (#4535) * Add deferred_credits initial file for test * Update Genesis and CI * Push back Genesis * Same --------- Signed-off-by: Jean-François <jfm@laposte.net> Co-authored-by: Damir Vodenicarevic <damipator@gmail.com> Co-authored-by: Moncef AOUDIA <ma@massa.net> Co-authored-by: Ursulafe <152976968+Ursulafe@users.noreply.github.com> Co-authored-by: Sydhds <sylvain.delhomme@gmail.com> Co-authored-by: sydhds <sydhds@gmail.com> Co-authored-by: Jean-François <jfm@laposte.net>
sydhds
added a commit
that referenced
this pull request
Dec 20, 2023
* Update addresses and public keys * Add more info to double staking protection's panic message * fmt * update version and genesis * Update version and CI * Update Cargo.lock * add community charter * Add serde json tests (#4579) * chore: typo fix (#4589) * Update to wasmer 4.2.4 (#4581) Co-authored-by: sydhds <sydhds@gmail.com> * typo fix * typo fix * typo fix * typo fix * typo fix --------- Co-authored-by: Sydhds <sylvain.delhomme@gmail.com> Co-authored-by: sydhds <sydhds@gmail.com> * ci: add checksum + tested with ACT (#4590) * Upgrade-to-latest-toolchain (#4585) Co-authored-by: Leo-Besancon <lb@massa.net> * Update massa-sc-runtime Signed-off-by: Jean-François <jfm@laposte.net> * Cargo update * Remove compatibility layer in tracing (#4535) * Add deferred_credits initial file for test * Update Genesis and CI * Push back Genesis * Same --------- Signed-off-by: Jean-François <jfm@laposte.net> Co-authored-by: Damir Vodenicarevic <damipator@gmail.com> Co-authored-by: Moncef AOUDIA <ma@massa.net> Co-authored-by: Ursulafe <152976968+Ursulafe@users.noreply.github.com> Co-authored-by: Sydhds <sylvain.delhomme@gmail.com> Co-authored-by: sydhds <sydhds@gmail.com> Co-authored-by: Jean-François <jfm@laposte.net>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 22, 2023
* Add initial chain id impl * Add chain id to jsonrpc, grpc public & grpc private api * Add massa-client features sandbox * Add chain id SC unit test * Fix unit test + add dummy gas costs * Update massa-proto-rs dependency * Update massa-sc-runtime dependency * Add unit test allowing easy update of massa docs * Use chain id through config instead of constants directly * Use chain id everywhere (round 1) (#4594) * Use chain id everywhere (round 1) * Use chain id in massa client --------- Co-authored-by: sydhds <sydhds@gmail.com> * Remove confusing chain id * Fix some unit tests * Test 27 6 wip (#4582) * Update addresses and public keys * Add more info to double staking protection's panic message * fmt * update version and genesis * Update version and CI * Update Cargo.lock * add community charter * Add serde json tests (#4579) * chore: typo fix (#4589) * Update to wasmer 4.2.4 (#4581) Co-authored-by: sydhds <sydhds@gmail.com> * typo fix * typo fix * typo fix * typo fix * typo fix --------- Co-authored-by: Sydhds <sylvain.delhomme@gmail.com> Co-authored-by: sydhds <sydhds@gmail.com> * ci: add checksum + tested with ACT (#4590) * Upgrade-to-latest-toolchain (#4585) Co-authored-by: Leo-Besancon <lb@massa.net> * Update massa-sc-runtime Signed-off-by: Jean-François <jfm@laposte.net> * Cargo update * Remove compatibility layer in tracing (#4535) * Add deferred_credits initial file for test * Update Genesis and CI * Push back Genesis * Same --------- Signed-off-by: Jean-François <jfm@laposte.net> Co-authored-by: Damir Vodenicarevic <damipator@gmail.com> Co-authored-by: Moncef AOUDIA <ma@massa.net> Co-authored-by: Ursulafe <152976968+Ursulafe@users.noreply.github.com> Co-authored-by: Sydhds <sylvain.delhomme@gmail.com> Co-authored-by: sydhds <sydhds@gmail.com> Co-authored-by: Jean-François <jfm@laposte.net> * Add initial chain id impl * Use chain id everywhere (round 1) (#4594) * Use chain id everywhere (round 1) * Use chain id in massa client --------- Co-authored-by: sydhds <sydhds@gmail.com> * Fix unit tests (final round) * Minor fix * Revert some nasty insert from bad rebase * Auto gen chain id from VERSION * Cargo clippy && fmt && doc pass * Update massa-sc-runtime dependency --------- Signed-off-by: Jean-François <jfm@laposte.net> Co-authored-by: sydhds <sydhds@gmail.com> Co-authored-by: Leo-Besancon <lb@massa.net> Co-authored-by: Damir Vodenicarevic <damipator@gmail.com> Co-authored-by: Moncef AOUDIA <ma@massa.net> Co-authored-by: Ursulafe <152976968+Ursulafe@users.noreply.github.com> Co-authored-by: Jean-François <jfm@laposte.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, found a few typos, mainly in ./massa-node. One of them is in a json file, rest are comments. This is a minor change. Have a nice afternoon.