Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of HistorySearchResult for fetched executed_ops/denunciations #4735

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Improve handling of HistorySearchResult for fetched executed_ops/denunciations #4735

merged 2 commits into from
Aug 2, 2024

Conversation

Leo-Besancon
Copy link
Collaborator

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@Leo-Besancon Leo-Besancon requested a review from bilboquet August 1, 2024 11:02
@Leo-Besancon Leo-Besancon added this pull request to the merge queue Aug 2, 2024
Merged via the queue into main with commit 77898f2 Aug 2, 2024
12 checks passed
sydhds pushed a commit that referenced this pull request Oct 2, 2024
@Leo-Besancon @sydhds
Improve handling of HistorySearchResult for fetched executed_ops/denu…
2d94edd 
…nciations (#4735)

* Improve handling of HistorySearchResult

* Fix CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilboquet bilboquet bilboquet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leo-Besancon @bilboquet