Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of HistorySearchResult for fetched executed_ops/denunciations #4735

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Improve handling of HistorySearchResult for fetched executed_ops/denunciations #4735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69adef4
Improve handling of HistorySearchResult
Leo-Besancon Aug 1, 2024
8e55d49
Fix CI
Leo-Besancon Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ jobs:
- uses: actions-rs/cargo@v1
with:
command: install
args: cargo-nextest
args: cargo-nextest --locked
- uses: actions-rs/cargo@v1
with:
command: nextest
Expand Down
4 changes: 1 addition & 3 deletions massa-execution-worker/src/speculative_executed_denunciations.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,8 @@ impl SpeculativeExecutedDenunciations {
HistorySearchResult::Present(_) => {
return true;
}
HistorySearchResult::Absent => {
return false;
}
HistorySearchResult::NoInfo => {}
HistorySearchResult::Absent => unreachable!(), // fetch_executed_denunciation does not return Absent
}

// check in the final state
Expand Down
4 changes: 1 addition & 3 deletions massa-execution-worker/src/speculative_executed_ops.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,8 @@ impl SpeculativeExecutedOps {
HistorySearchResult::Present(_) => {
return true;
}
HistorySearchResult::Absent => {
return false;
}
HistorySearchResult::NoInfo => {}
HistorySearchResult::Absent => unreachable!(), // fetch_executed_op does not return Absent
}

// check in the final state
Expand Down
Loading