'Solution' #1222
'Solution' #1222
Conversation
app/main.py
Outdated
| def __init__(self, | ||
| name: str, | ||
| is_hungry: bool = True | ||
| ) -> None: |
There was a problem hiding this comment.
Place each argument including self on a new line so that there would be no arguments on the same line with opening and closing parenthesis here and in the Dog class as well. It will help to improve the code style and readability
app/main.py
Outdated
| print(f"Eating {self.appetite} food points...") | ||
| self.is_hungry = False | ||
| return self.appetite | ||
| else: |
There was a problem hiding this comment.
There is no need for else since the code will not execute after the return statement anyway. Please, remove the redundant else
app/main.py
Outdated
| def __init__( | ||
| self, | ||
| name: str, | ||
| appetite: float, |
There was a problem hiding this comment.
appetite could be int as well, add it to the type annotation
app/main.py
Outdated
| total_food_points = 0 | ||
| for animal in animals: | ||
| if animal.is_hungry: | ||
| total_food_points += animal.feed() | ||
| return total_food_points |
There was a problem hiding this comment.
Implement this method in one line using sum. There is no need to check if animal is hungry here since it is done in the feed method
app/main.py
Outdated
| else: | ||
| return 0 |
There was a problem hiding this comment.
Please, remove the redundant else and leave the return statement
| else: | |
| return 0 | |
| return 0 |
app/main.py
Outdated
|
|
||
|
|
||
| def feed_animals(animals: list[Animal]) -> int: | ||
| return sum(animal.feed() for animal in animals if animal.is_hungry) |
There was a problem hiding this comment.
There is no need to perform the if check here, it is already done in the feed method
| return sum(animal.feed() for animal in animals if animal.is_hungry) | |
| return sum(animal.feed() for animal in animals) |
No description provided.