Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Solution' #1222

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 54 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,54 @@
# write your code here
class Animal:
def __init__(
self,
name: str,
appetite: float,
is_hungry: bool = True

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appetite could be int as well, add it to the type annotation

) -> None:
self.name = name
self.appetite = appetite
self.is_hungry = is_hungry

def print_name(self) -> None:
print(f"Hello, I'm {self.name}")

def feed(self) -> float:
if self.is_hungry:
print(f"Eating {self.appetite} food points...")
self.is_hungry = False
return self.appetite
else:
return 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need for else since the code will not execute after the return statement anyway. Please, remove the redundant else

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove the redundant else and leave the return statement

Suggested change
else:
return 0
return 0


class Cat(Animal):
def __init__(self,
name: str,
is_hungry: bool = True
) -> None:
super().__init__(name, appetite=3, is_hungry=is_hungry)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Place each argument including self on a new line so that there would be no arguments on the same line with opening and closing parenthesis here and in the Dog class as well. It will help to improve the code style and readability


@staticmethod
def catch_mouse() -> None:
print("The hunt began!")


class Dog(Animal):
def __init__(
self,
name: str,
is_hungry: bool = True
) -> None:
super().__init__(name, appetite=7, is_hungry=is_hungry)

@staticmethod
def bring_slippers() -> None:
print("The slippers delivered!")


def feed_animals(animals: list[Animal]) -> int:
total_food_points = 0
for animal in animals:
if animal.is_hungry:
total_food_points += animal.feed()
return total_food_points
Loading