Update main.py #1638
Update main.py #1638
Conversation
There was a problem hiding this comment.
Thank you for your submission! 🎉 Your code meets the task requirements and constraints, and you've done a great job defining the Person class and the create_person_list function. However, there are a few critical issues that need attention:
-
Class Variable Access: The
peopledictionary is defined as a class variable, but it is being accessed as an instance variable in the__init__method. You should usePerson.peopleto reference the class variable. For example, changeself.people[name] = selftoPerson.people[name] = self. -
Syntax Error: There is a syntax error due to the incorrect use of a line continuation character
\. This character is not needed, and you can write the assignment in a single line or split it correctly without the backslash.
These issues are important for the functionality of your code, and addressing them will help you avoid similar problems in the future. Please review the comments and make the necessary improvements. Keep up the great work, and continue learning from your experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -1,8 +1,21 @@ | |||
| class Person: | |||
| # write your code here | |||
| pass | |||
| people = {} | |||
There was a problem hiding this comment.
The people dictionary is defined as a class variable, but it is being accessed as an instance variable in the __init__ method. You should use Person.people to reference the class variable.
| def __init__(self, name: str, age: int) -> None: | ||
| self.name = name | ||
| self.age = age | ||
| self.people[name] = self |
There was a problem hiding this comment.
Here, self.people[name] = self should be Person.people[name] = self to correctly reference the class variable people.
| if human.get("wife"): | ||
| Person.people[human["name"]].wife = Person.people[human["wife"]] | ||
| if human.get("husband"): | ||
| Person.people[human["name"]].husband \ |
There was a problem hiding this comment.
There is a syntax error here. The line continuation character \ is not needed. You can write the assignment in a single line or split it correctly without the backslash.
No description provided.