Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main.py #1638

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update main.py #1638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,21 @@
class Person:
# write your code here
pass
people = {}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The people dictionary is defined as a class variable, but it is being accessed as an instance variable in the __init__ method. You should use Person.people to reference the class variable.


def __init__(self, name: str, age: int) -> None:
self.name = name
self.age = age
self.people[name] = self
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, self.people[name] = self should be Person.people[name] = self to correctly reference the class variable people.



def create_person_list(people: list) -> list:
# write your code here
pass
for human in people:
Person(human["name"], human["age"])

for human in people:
if human.get("wife"):
Person.people[human["name"]].wife = Person.people[human["wife"]]
if human.get("husband"):
Person.people[human["name"]].husband \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a syntax error here. The line continuation character \ is not needed. You can write the assignment in a single line or split it correctly without the backslash.

= Person.people[human["husband"]]

return list(Person.people.values())
Loading