Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete #1658

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Complete #1658

wants to merge 1 commit into from

Conversation

Atom-gnomov
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the Person class and the create_person_list function! 🎉 Your code meets the task requirements and constraints effectively. While there are a couple of minor improvements you could make, such as using dict.get() to avoid potential KeyError exceptions and simplifying the code by removing redundant checks for wife and husband attributes, these do not impact the core functionality. Keep up the good work and continue refining your coding skills! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +22 to +23
if hasattr(human, "husband"):
del human.husband

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check and deletion of the husband attribute when setting a wife is redundant. Since the husband attribute is not set when a wife is being assigned, this block can be removed to simplify the code.

Comment on lines +27 to +28
if hasattr(human, "wife"):
del human.wife

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, the check and deletion of the wife attribute when setting a husband is redundant. This block can be removed as it does not affect the functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants