Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete #1658

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 32 additions & 4 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,36 @@
class Person:
# write your code here
pass
people = {}

def __init__(self, name: str, age: int) -> None:
self.name = name
self.age = age
self.wife = None
self.husband = None
Person.people[name] = self


def create_person_list(people: list) -> list:
# write your code here
pass
for i in people:
Person(i["name"], i["age"])

for i in people:
name = i["name"]
human = Person.people[name]

if "wife" in i and i["wife"]:
human.wife = Person.people[i["wife"]]
if hasattr(human, "husband"):
del human.husband
Comment on lines +22 to +23

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check and deletion of the husband attribute when setting a wife is redundant. Since the husband attribute is not set when a wife is being assigned, this block can be removed to simplify the code.


elif "husband" in i and i["husband"]:
human.husband = Person.people[i["husband"]]
if hasattr(human, "wife"):
del human.wife
Comment on lines +27 to +28

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, the check and deletion of the wife attribute when setting a husband is redundant. This block can be removed as it does not affect the functionality.


else:
if hasattr(human, "wife"):
del human.wife
if hasattr(human, "husband"):
del human.husband

return list(Person.people.values())
Loading