Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solution #1733

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

solution #1733

wants to merge 1 commit into from

Conversation

Krrampuss
Copy link

AlyonaV22
AlyonaV22 approved these changes Dec 26, 2024
View reviewed changes
Copy link

@AlyonaV22 AlyonaV22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! In the component Table you can create an enum and use it in the line 22, if you want.

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Dec 26, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🎉 Your code meets all the task requirements and is well-implemented. Everything from routing to component structure is spot on. Keep up the excellent work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

BudnikOleksii
BudnikOleksii approved these changes Dec 26, 2024
View reviewed changes
Copy link

@BudnikOleksii BudnikOleksii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done 🚀

src/components/PeopleTable.tsx
mother,
father,
} = person;

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can put const isSelected = person.slug === slug; here instead

src/components/PeopleTable.tsx
return (
<tr
key={person.slug}
data-cy="person"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a person component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlyonaV22 AlyonaV22 AlyonaV22 approved these changes

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

@BudnikOleksii BudnikOleksii BudnikOleksii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Krrampuss @BudnikOleksii @mateacademy-ai-mentor @AlyonaV22