solution #1733
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import { HashRouter, Navigate, Route, Routes } from 'react-router-dom'; | ||
| import { App } from '../App'; | ||
| import { HomePage } from '../components/HomePage'; | ||
| import { PeoplePage } from '../components/PeoplePage'; | ||
| import { NotFound } from '../components/NotFound'; | ||
|
|
||
| export const Root = () => ( | ||
| <> | ||
| <HashRouter> | ||
| <Routes> | ||
| <Route path="/" element={<App />}> | ||
| <Route index element={<HomePage />} /> | ||
| <Route path="/home" element={<Navigate replace to="/" />} /> | ||
|
|
||
| <Route path="people"> | ||
| <Route index element={<PeoplePage />} /> | ||
| <Route path=":slug?" element={<PeoplePage />} /> | ||
| </Route> | ||
| <Route path="*" element={<NotFound />} /> | ||
| </Route> | ||
| </Routes> | ||
| </HashRouter> | ||
| </> | ||
| ); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export const HomePage = () => <h1 className="title">Home Page</h1>; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export const NotFound = () => <h1 className="title">Page not found</h1>; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import { Link } from 'react-router-dom'; | ||
| import { Person } from '../types'; | ||
| import cn from 'classnames'; | ||
|
|
||
| type Props = { | ||
| person: Person; | ||
| }; | ||
|
|
||
| export const PersonLink: React.FC<Props> = ({ person }) => { | ||
| const { slug, sex, name } = person; | ||
|
|
||
| return ( | ||
| <Link | ||
| to={`/people/${slug}`} | ||
| className={cn({ 'has-text-danger': sex === 'f' })} | ||
| > | ||
| {name} | ||
| </Link> | ||
| ); | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| import { useEffect, useState } from 'react'; | ||
| import { Loader } from './Loader'; | ||
| import { getPeople } from '../api'; | ||
| import { Person } from '../types'; | ||
| import { Error } from '../types/Error'; | ||
| import { Table } from './PeopleTable'; | ||
|
|
||
| export const PeoplePage = () => { | ||
| const [isLoading, setIsLoading] = useState(false); | ||
| const [people, setPeople] = useState<Person[]>([]); | ||
| const [error, setError] = useState(Error.Default); | ||
|
|
||
| const loadPeople = () => { | ||
| setIsLoading(true); | ||
| setError(Error.Default); | ||
|
|
||
| getPeople() | ||
| .then(peop => { | ||
| const peopleWithFamily = peop.map(person => { | ||
| const father = peop.find(pers => pers.name === person.fatherName); | ||
| const mother = peop.find(pers => pers.name === person.motherName); | ||
|
|
||
| return { | ||
| ...person, | ||
| father, | ||
| mother, | ||
| }; | ||
| }); | ||
|
|
||
| setPeople(peopleWithFamily); | ||
| }) | ||
| .catch(() => setError(Error.Load)) | ||
| .finally(() => setIsLoading(false)); | ||
| }; | ||
|
|
||
| useEffect(() => { | ||
| loadPeople(); | ||
| }, []); | ||
|
|
||
| return ( | ||
| <> | ||
| <h1 className="title">People Page</h1> | ||
| <div className="box table-container"> | ||
| {isLoading && !error && <Loader />} | ||
| {error && ( | ||
| <p data-cy="peopleLoadingError" className="has-text-danger"> | ||
| {error} | ||
| </p> | ||
| )} | ||
|
|
||
| {people.length === 0 && !error && !isLoading && ( | ||
| <p data-cy="noPeopleMessage">There are no people on the server</p> | ||
| )} | ||
| {!isLoading && people.length > 0 && <Table people={people} />} | ||
| </div> | ||
| </> | ||
| ); | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| import { useParams } from 'react-router-dom'; | ||
| import { Person } from '../types'; | ||
| import cn from 'classnames'; | ||
| import { PersonLink } from './PeopleLink'; | ||
|
|
||
| type Props = { | ||
| people: Person[]; | ||
| }; | ||
|
|
||
| export const Table: React.FC<Props> = ({ people }) => { | ||
| const { slug } = useParams(); | ||
|
|
||
| const isSelected = people.find(person => person.slug === slug); | ||
|
|
||
| return ( | ||
| <table | ||
| data-cy="peopleTable" | ||
| className="table is-striped is-hoverable is-narrow is-fullwidth" | ||
| > | ||
| <thead> | ||
| <tr> | ||
| <th>Name</th> | ||
| <th>Sex</th> | ||
| <th>Born</th> | ||
| <th>Died</th> | ||
| <th>Mother</th> | ||
| <th>Father</th> | ||
| </tr> | ||
| </thead> | ||
|
|
||
| <tbody> | ||
| {people.map(person => { | ||
| const { | ||
| sex, | ||
| born, | ||
| died, | ||
| fatherName, | ||
| motherName, | ||
| slug: personSlug, | ||
| mother, | ||
| father, | ||
| } = person; | ||
|
|
||
| return ( | ||
| <tr | ||
| key={person.slug} | ||
| data-cy="person" | ||
|
|
||
| className={cn({ | ||
| 'has-background-warning': isSelected?.slug === personSlug, | ||
| })} | ||
| > | ||
| <td> | ||
| <PersonLink person={person} /> | ||
| </td> | ||
|
|
||
| <td>{sex}</td> | ||
| <td>{born}</td> | ||
| <td>{died}</td> | ||
|
|
||
| <td> | ||
| {mother ? <PersonLink person={mother} /> : motherName || '-'} | ||
| </td> | ||
|
|
||
| <td> | ||
| {father ? <PersonLink person={father} /> : fatherName || '-'} | ||
| </td> | ||
| </tr> | ||
| ); | ||
| })} | ||
| </tbody> | ||
| </table> | ||
| ); | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,7 @@ | ||
| import { createRoot } from 'react-dom/client'; | ||
|
|
||
| import 'bulma/css/bulma.css'; | ||
| import '@fortawesome/fontawesome-free/css/all.css'; | ||
| import { Root } from './Router/Root'; | ||
|
|
||
| createRoot(document.getElementById('root') as HTMLDivElement).render(<Root />); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| export enum Error { | ||
| Default = '', | ||
| Load = 'Unable to load data', | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| import cn from 'classnames'; | ||
|
|
||
| export const getLinkClass = ({ isActive }: { isActive: boolean }) => | ||
| cn('navbar-item', { | ||
| 'has-background-grey-lighter': isActive, | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can put
const isSelected = person.slug === slug;here instead