Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar: Wrong placement of last icon when there is a menu #1026

Closed
touficbatache opened this issue Jul 27, 2017 · 2 comments · Fixed by #1068
Closed

Toolbar: Wrong placement of last icon when there is a menu #1026

touficbatache opened this issue Jul 27, 2017 · 2 comments · Fixed by #1068

Comments

@touficbatache
Copy link
Contributor

Bugs

What MDC-Web Version are you using?

0.16.0

What browser(s) is this bug affecting?

All browsers

What OS are you using?

Windows 7

What are the steps to reproduce the bug?

  1. Have a toolbar like here
  2. Add a simple menu to the most right icon
  3. Observe the right padding (placement) of the last icon

What is the expected behavior?

It should have a padding-right: 16px;

What is the actual behavior?

It has a padding-right: 8px; (like normal icons)

Any other information you believe would be useful?

This is caused by mdc-toolbar__icon:last-child. The toolbar icon isn't the last child because there is a simple menu after it. A simple fix would be to use last-of-type instead of last-child.
Would you like a PR to fix this?

@yeelan0319
Copy link
Contributor

Sounds reasonable. Feel free to file an PR for it.

@touficbatache
Copy link
Contributor Author

Done! @yeelan0319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants