-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(toolbar): Wrong placement of last icon when there is a menu #1068
fix(toolbar): Wrong placement of last icon when there is a menu #1068
Conversation
Should we have an example of this added to the toolbar demos? Maybe addressable separately but IIUC there's nothing OOTB that demonstrates the issue/fix right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kfranqueiro is right, we should add an example of this in our demos directory.
I can do that, so from what I unrderstood I should add an example with the menu, correct? |
Yes, specifically what I had in mind was add another example to the toolbar demos that contains a menu on the last icon. It should then be easy to test with/without the CSS change to see the fix. |
I made the necessary changes! @yeelan0319 @kfranqueiro |
Codecov Report
@@ Coverage Diff @@
## master #1068 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 68 68
Lines 3296 3296
Branches 405 405
=======================================
Hits 3294 3294
Misses 2 2 Continue to review full report at Codecov.
|
Fixes and closes #1026 @yeelan0319