Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(toolbar): Wrong placement of last icon when there is a menu #1068

Merged
merged 5 commits into from
Aug 9, 2017
Merged

fix(toolbar): Wrong placement of last icon when there is a menu #1068

merged 5 commits into from
Aug 9, 2017

Conversation

touficbatache
Copy link
Contributor

Fixes and closes #1026 @yeelan0319

@kfranqueiro
Copy link
Contributor

Should we have an example of this added to the toolbar demos? Maybe addressable separately but IIUC there's nothing OOTB that demonstrates the issue/fix right now.

Copy link
Contributor

@lynnmercier lynnmercier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kfranqueiro is right, we should add an example of this in our demos directory.

@lynnmercier lynnmercier self-assigned this Aug 7, 2017
@touficbatache
Copy link
Contributor Author

I can do that, so from what I unrderstood I should add an example with the menu, correct?

@kfranqueiro
Copy link
Contributor

Yes, specifically what I had in mind was add another example to the toolbar demos that contains a menu on the last icon. It should then be easy to test with/without the CSS change to see the fix.

@touficbatache
Copy link
Contributor Author

I made the necessary changes! @yeelan0319 @kfranqueiro

@codecov-io
Copy link

codecov-io commented Aug 8, 2017

Codecov Report

Merging #1068 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1068   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          68       68           
  Lines        3296     3296           
  Branches      405      405           
=======================================
  Hits         3294     3294           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 264c154...7dc89ec. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolbar: Wrong placement of last icon when there is a menu
4 participants