feat(switch): Merge updated switch into master #3214

rlfriedman · 2018-07-25T18:50:15Z

BREAKING CHANGE: MDC Switch DOM structure and Sass APIs have changed, and JavaScript APIs have been added. See the documentation for more information.

Fixes #2825

…and (#3119)

codecov-io · 2018-07-25T18:50:42Z

Codecov Report

Merging #3214 into master will increase coverage by 0.01%.
The diff coverage is 98.83%.

@@            Coverage Diff             @@
##           master    #3214      +/-   ##
==========================================
+ Coverage   98.12%   98.13%   +0.01%     
==========================================
  Files         101      104       +3     
  Lines        4421     4507      +86     
  Branches      585      587       +2     
==========================================
+ Hits         4338     4423      +85     
- Misses         83       84       +1

Impacted Files	Coverage Δ
packages/mdc-switch/constants.js	`100% <100%> (ø)`
packages/mdc-switch/foundation.js	`100% <100%> (ø)`
packages/mdc-switch/index.js	`98% <98%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b95d4e7...b5570a5. Read the comment docs.

…3224) This reverts commit 6d61cb9.

chore(switch): Merge master into feat/switch-update

mdc-web-bot · 2018-07-26T00:29:55Z

Screenshot test report ⚠️

12 screenshots changed from master on commit 82b8490:

https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2018/07/26/00_29_15_629/report/report.html

Details

12 Added:

kfranqueiro

I started looking this over but will need to continue later. Pointed out a few things I noticed.

kfranqueiro · 2018-07-26T17:29:23Z

.travis.yml

@@ -6,6 +6,7 @@ branches:
  # This prevents excessive resource usage and CI slowness.
  only:
  - master
+  - feat/switch-update


This should be removed in the merge

kfranqueiro · 2018-07-26T17:30:55Z

packages/material-components-web/README.md

@@ -26,6 +26,7 @@ const checkbox = new mdc.checkbox.MDCCheckbox(document.querySelector('.mdc-check
 import { checkbox } from 'material-components-web';
 const checkbox = new checkbox.MDCCheckbox(document.querySelector('.mdc-checkbox'));
 ```
+> NOTE: Since switch is a reserved word in JS, switch is instead named `switchControl`. 


Add a newline before this line

kfranqueiro · 2018-07-26T18:01:19Z

packages/mdc-switch/README.md

+  <div class="mdc-switch__thumb-underlay">
+    <div class="mdc-switch__thumb">
+        <input type="checkbox" id="basic-switch" class="mdc-switch__native-control" role="switch">
+    </div>


The basic usage section seems to be missing the Styles (for imports) and JavaScript Instantiation sections

Good catch, will add!

kfranqueiro · 2018-07-26T18:01:46Z

packages/mdc-switch/README.md

+`mdc-switch__thumb` | Mandatory, for the thumb element.
+`mdc-switch__native-control` | Mandatory, for the hidden input checkbox.
+
+## Style Customization


There's already a style customization heading above, I think this one shouldn't be here

Thanks, will remove.

kfranqueiro · 2018-07-26T18:03:16Z

packages/mdc-switch/README.md

+
+## Usage within Web Frameworks
+
+If you are using a JavaScript framework, such as React or Angular, you can create a switch for your framework. Depending on your needs, you can use the _Simple Approach: Wrapping MDC Web Vanilla Components_, or the _Advanced Approach: Using Foundations and Adapters_. Please follow the instructions [here](../../docs/integrating-into-frameworks.md).


Capitalize "Switch" in "create a switch for your framework"

kfranqueiro · 2018-07-26T18:03:50Z

packages/mdc-switch/README.md

+| `setDisabled(disabled: boolean) => void` | Sets the disabled value of the native control and updates styling to reflect the disabled state. |
+| `handleChange() => void` | Handles a change event from the native control. |
+
+### `MDCSwitchFoundation` Event Handlers


Shouldn't this be documented under the component rather than the foundation?

I just re-read this and realized why it's here; I had misread it earlier. This is basically an example of the sort of thing Pat was saying we should add, so this can stay here.

mdc-web-bot · 2018-07-26T18:26:38Z

Screenshot test report ⚠️

12 screenshots changed from master on commit 2413731:

https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2018/07/26/18_26_01_798/report/report.html

Details

12 Added:

moog16 · 2018-07-26T23:13:12Z

packages/mdc-switch/package.json

@@ -8,17 +8,22 @@
    "material design",
    "switch"
  ],
+  "main": "index.js",


please point this to dist/mdc.switch.js

I can't find a single other package we're doing this for in MDC Web and thus think this is a mistake...

Can you explain this @moog16 ? At the very least I don't think we should be making one package inconsistent from the rest right now.

Okay, I just found #3245, which explains this.

I don't think we should be rushing to do that just yet - please revert this here.

sorry @rlfriedman! I jumped the gun :)

mdc-web-bot · 2018-07-27T00:50:52Z

Screenshot test report ⚠️

12 screenshots changed from master on commit 9becfc8:

https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2018/07/27/00_50_13_237/report/report.html

Details

12 Added:

This reverts commit 9becfc8.

mdc-web-bot · 2018-07-27T15:44:56Z

Screenshot test report ⚠️

12 screenshots changed from master on commit de825d9:

https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2018/07/27/15_44_12_633/report/report.html

Details

12 Added:

kfranqueiro

This will need a proper BREAKING CHANGE description in the commit description when merging, e.g.:

BREAKING CHANGE: MDC Switch DOM structure and Sass APIs have changed, and JavaScript APIs have been added. See the documentation for more information.

mdc-web-bot · 2018-07-27T16:26:23Z

Screenshot test report ⚠️

12 screenshots changed from master on commit b5570a5:

https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2018/07/27/16_25_46_231/report/report.html

Details

12 Added:

rlfriedman and others added 10 commits May 24, 2018 16:30

WIP: Clear out old switch styles and docs.

133698c

chore: run travis on feat/switch-update (#2876)

e3e400d

feat(switch): Update switch to use JS and have ripple (#2915)

bedd674

fix(switch): Fix switch styling in IE and Firefox (#3071)

e071d07

fix(switch): Allow pointer events to get to the native control on IE …

235b132

…and (#3119)

Merge master into feat/switch-update (#3138)

c508c29

fix(switch): Fix showing switch ripple focus state in Edge (#3143)

c6e37a5

fix(switch): Update switch checked styling on foundation init (#3147)

293bdba

fix(switch): Update switch styling to match the design spec (#3153)

5b0f71c

chore(switch): Add screenshot tests for switch (#3167)

4584f00

Matt Goo and others added 9 commits July 25, 2018 12:04

Merge branch 'master' into feat/switch-update

47c4147

WIP: Fix some issues with merging

35dd8b0

WIP: Fix more merging issues

7b473b5

WIP: Fix screenshot json merging

eabcc62

WIP: Add back line to allow travis to run on switch-update

72ec918

Merge branch 'master' into fix/switch/WATERMASTER

209b557

chore(switch): Merge master into feat/switch-update (#3215)

6d61cb9

Revert "chore(switch): Merge master into feat/switch-update (#3215)" (#…

288a183

…3224) This reverts commit 6d61cb9.

Merge pull request #3225 from material-components/fix/switch/WATERMASTER

82b8490

chore(switch): Merge master into feat/switch-update

rlfriedman changed the title ~~Feat/switch update~~ feat(switch): Merge updated switch into master Jul 26, 2018

Merge branch 'master' into chore/water-master

a3332e4

kfranqueiro suggested changes Jul 26, 2018

View reviewed changes

Merge pull request #3235 from material-components/chore/water-master

2413731

kfranqueiro mentioned this pull request Jul 26, 2018

Update switch catalog page to work with updated Switch coming in 0.38 material-components/material-components-web-catalog#175

Closed

rlfriedman mentioned this pull request Jul 26, 2018

fix(switch): Switch README updates #3241

Merged

fix(switch): Switch README updates (#3241)

ae3c90a

moog16 reviewed Jul 26, 2018

View reviewed changes

WIP: Fix main path

9becfc8

WIP Revert "WIP: Fix main path"

de825d9

This reverts commit 9becfc8.

kfranqueiro approved these changes Jul 27, 2018

View reviewed changes

Merge branch 'master' into feat/switch-update

b5570a5

rlfriedman merged commit 19724f1 into master Jul 27, 2018

jamesmfriedman mentioned this pull request Jul 30, 2018

MDC 38/39 rmwc/rmwc#281

Closed

48 tasks

This was referenced Jul 30, 2018

Update to material-components-web v0.38.0 trimox/angular-mdc-web#1162

Closed

Update MDC Switch to new spec trimox/angular-mdc-web#1170

Closed

kfranqueiro deleted the feat/switch-update branch August 13, 2018 20:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(switch): Merge updated switch into master #3214

feat(switch): Merge updated switch into master #3214

rlfriedman commented Jul 25, 2018 •

edited

Loading

codecov-io commented Jul 25, 2018 •

edited

Loading

mdc-web-bot commented Jul 26, 2018

12 Added:

kfranqueiro left a comment

kfranqueiro Jul 26, 2018

rlfriedman Jul 26, 2018

kfranqueiro Jul 26, 2018

rlfriedman Jul 26, 2018

kfranqueiro Jul 26, 2018

rlfriedman Jul 26, 2018

kfranqueiro Jul 26, 2018

rlfriedman Jul 26, 2018

kfranqueiro Jul 26, 2018

rlfriedman Jul 26, 2018

kfranqueiro Jul 26, 2018

kfranqueiro Jul 26, 2018

mdc-web-bot commented Jul 26, 2018

12 Added:

moog16 Jul 26, 2018 •

edited

Loading

rlfriedman Jul 27, 2018

kfranqueiro Jul 27, 2018 •

edited

Loading

kfranqueiro Jul 27, 2018

moog16 Jul 27, 2018

mdc-web-bot commented Jul 27, 2018

12 Added:

mdc-web-bot commented Jul 27, 2018

12 Added:

kfranqueiro left a comment

mdc-web-bot commented Jul 27, 2018

12 Added:


		## Usage within Web Frameworks

		If you are using a JavaScript framework, such as React or Angular, you can create a switch for your framework. Depending on your needs, you can use the _Simple Approach: Wrapping MDC Web Vanilla Components_, or the _Advanced Approach: Using Foundations and Adapters_. Please follow the instructions [here](../../docs/integrating-into-frameworks.md).

feat(switch): Merge updated switch into master #3214

feat(switch): Merge updated switch into master #3214

Conversation

rlfriedman commented Jul 25, 2018 • edited Loading

codecov-io commented Jul 25, 2018 • edited Loading

Codecov Report

mdc-web-bot commented Jul 26, 2018

Screenshot test report ⚠️

12 Added:

kfranqueiro left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mdc-web-bot commented Jul 26, 2018

Screenshot test report ⚠️

12 Added:

moog16 Jul 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kfranqueiro Jul 27, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mdc-web-bot commented Jul 27, 2018

Screenshot test report ⚠️

12 Added:

mdc-web-bot commented Jul 27, 2018

Screenshot test report ⚠️

12 Added:

kfranqueiro left a comment

Choose a reason for hiding this comment

mdc-web-bot commented Jul 27, 2018

Screenshot test report ⚠️

12 Added:

rlfriedman commented Jul 25, 2018 •

edited

Loading

codecov-io commented Jul 25, 2018 •

edited

Loading

moog16 Jul 26, 2018 •

edited

Loading

kfranqueiro Jul 27, 2018 •

edited

Loading