chore: Add tests for webpack.config.js module exports #2181
Conversation
Adds `npm run test:buildconfig` command, and runs it during `npm test`. Replaces `;` with `&&` in `package.json` (Windows `cmd.exe` does not support `;`). Prerequisite for #1994
Codecov Report
@@ Coverage Diff @@
## master #2181 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 90 90
Lines 3843 3843
Branches 497 497
=======================================
Hits 3810 3810
Misses 33 33Continue to review full report at Codecov.
|
package.json
Outdated
| @@ -19,12 +19,13 @@ | |||
| "lint": "npm-run-all --parallel lint:*", | |||
| "postinstall": "lerna bootstrap", | |||
| "pretest": "npm run lint && node scripts/check-imports.js", | |||
| "test": "npm run test:unit && npm run test:closure && npm run test:dependency && npm run build; npm run clean", | |||
| "test": "npm run test:buildconfig && npm run test:unit && npm run test:closure && npm run test:dependency && npm run build && npm run clean", | |||
There was a problem hiding this comment.
Move this to the end of the tests. Most people just run Unit tests and then force quit because they don't want to wait (at least thats what happens to me)
There was a problem hiding this comment.
test:buildconfig takes less than 1 second to run.
I originally had it at the end, but I got tired of waiting for test:unit to finish 😀
There was a problem hiding this comment.
People shouldn't be force-quitting after running unit tests though? At least, not if they want to make sure that everything actually works... (And if they really only want to run unit tests... npm run test:unit)
There might actually be solid argument for putting the fast-running things (e.g. test:buildconfig and build) first since if we manage to do something silly that fails fast, it'd be better for Travis CI to get it over with quick and move on to other jobs. We can do that separately from this PR though.
npm run test:buildconfigcommand, and calls it innpm test;with&&inpackage.json(Windowscmd.exedoes not support;)To test this PR, simply change a single character in a
test/build/goldens/*.jsonfile.Then run
npm run test:buildconfigin the console.This PR is a prerequisite for #1994.