Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract webpack.demo.js from webpack.config.js #1994

Closed
lynnmercier opened this issue Jan 18, 2018 · 0 comments
Closed

Extract webpack.demo.js from webpack.config.js #1994

lynnmercier opened this issue Jan 18, 2018 · 0 comments
Assignees
@acdvorak
Labels
backlog

Comments

@lynnmercier
Copy link
Contributor

This is a prerequisite to our new screenshot testing directory
@lynnmercier lynnmercier changed the title Move webpack.config.js into demo directory Extract webpack.demo.js from webpack.config.js Feb 2, 2018
acdvorak added a commit that referenced this issue Feb 3, 2018
@acdvorak
chore: Add tests for webpack.config.js module exports
36d8384 
Adds `npm run test:buildconfig` command, and runs it during `npm test`.

Replaces `;` with `&&` in `package.json` (Windows `cmd.exe` does not support `;`).

Prerequisite for #1994
@acdvorak acdvorak mentioned this issue Feb 3, 2018
Merged
@acdvorak acdvorak self-assigned this Feb 5, 2018
acdvorak added a commit that referenced this issue Feb 5, 2018
@acdvorak
chore: Add tests for webpack.config.js module exports (#2181)
874e24f 
- Adds an `npm run test:buildconfig` command (called from `npm test`)
- Replaces `;` with `&&` in `package.json` (Windows `cmd.exe` does not support `;`)

To test this PR, simply change a single character in a `test/build/goldens/*.json` file.
Then run `npm run test:buildconfig` in the console.

This PR is a prerequisite for #1994.
acdvorak added a commit that referenced this issue Feb 28, 2018
@acdvorak
chore: Extract webpack.demo.js from webpack.config.js
fbe5e04 
Fixes #1994
acdvorak added a commit that referenced this issue Feb 28, 2018
@acdvorak
chore: Extract webpack.demo.js from webpack.config.js
e54c250 
Fixes #1994
@acdvorak acdvorak mentioned this issue Feb 28, 2018
Merged
acdvorak added a commit that referenced this issue Mar 9, 2018
@acdvorak
chore: Move demo Webpack config to separate file
102f6cf 
Fixes #1994
acdvorak added a commit that referenced this issue Mar 9, 2018
@acdvorak
chore: Move demo Webpack config to separate file
b3790ee 
Fixes #1994
acdvorak added a commit that referenced this issue Mar 9, 2018
@acdvorak
chore: Move demo Webpack config to separate file
a5fffd5 
Fixes #1994
acdvorak added a commit that referenced this issue Mar 9, 2018
@acdvorak
chore: Move demo Webpack config to separate file (#2325)
4c7f006 
Fixes #1994
williamernest pushed a commit that referenced this issue Mar 14, 2018
@acdvorak @williamernest
chore: Move demo Webpack config to separate file (#2325)
b1d746b 
Fixes #1994
acdvorak added a commit that referenced this issue Mar 22, 2018
@acdvorak
chore(infrastructure): Delete Webpack config tests
0ce7f54 
No longer needed now that Webpack config refactoring is complete.

Refs #1994
@acdvorak acdvorak mentioned this issue Mar 22, 2018
Merged
acdvorak added a commit that referenced this issue Mar 22, 2018
@acdvorak
chore(infrastructure): Delete Webpack config tests (#2450)
9e5d646 
No longer needed now that Webpack config refactoring is complete.

Refs #1994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acdvorak acdvorak

Labels
backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@acdvorak @lynnmercier