feat(rtl): Make mdc-rtl-reflexive sass mixin public #2823
Conversation
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
abhiomkar
force-pushed
the
fix_rtl_reflexive_public_issue2392
branch
from
0b076f2 to
054cc5e
Compare
|
CLAs look good, thanks! |
packages/mdc-ripple/package.json
Outdated
| "dependencies": { | ||
| "@material/base": "^0.35.0", | ||
| "@material/theme": "^0.35.0", | ||
| "@material/animation": "^0.34.0" |
There was a problem hiding this comment.
@material/animation is required for the $mdc-animation-standard-curve-timing-function variable in _mixins.scss
There was a problem hiding this comment.
Looks like I messed up with resetting the commits. This change is not supposed to be here. Reverting these changes.
Codecov Report
@@ Coverage Diff @@
## master #2823 +/- ##
=======================================
Coverage 98.42% 98.42%
=======================================
Files 98 98
Lines 4203 4203
Branches 534 534
=======================================
Hits 4137 4137
Misses 66 66Continue to review full report at Codecov.
|
packages/mdc-rtl/_mixins.scss
Outdated
| // } | ||
| // } | ||
| // ``` | ||
| // An optional third $root-selector argument may also be given, which is passed to `mdc-rtl`. |
kfranqueiro
changed the title
5 participants
Changes required for Issue #2392
Follow up PR #2816
Also updated the docs and usage in top app bar.