feat(tab-indicator): Convert JS to TypeScript #4391
Conversation
Codecov Report
@@ Coverage Diff @@
## feat/typescript #4391 +/- ##
===================================================
- Coverage 98.65% 98.65% -0.01%
===================================================
Files 94 94
Lines 5965 5962 -3
Branches 801 803 +2
===================================================
- Hits 5885 5882 -3
Misses 79 79
Partials 1 1
Continue to review full report at Codecov.
|
|
All 621 screenshot tests passed for commit b74c160 vs. |
|
All 621 screenshot tests passed for commit 0274904 vs. |
|
All 621 screenshot tests passed for commit a295e93 vs. |
|
All 621 screenshot tests passed for commit 5002226 vs. |
| @@ -56,7 +56,9 @@ test('#activate does not modify transform and does not transition if no client r | |||
| }); | |||
|
|
|||
| test(`#deactivate removes the ${MDCSlidingTabIndicatorFoundation.cssClasses.ACTIVE} class`, () => { | |||
| const {foundation, mockAdapter} = setupTest(); | |||
| const foundation = new MDCSlidingTabIndicatorFoundation(); | |||
There was a problem hiding this comment.
Why was this test changed to use a real adapter with one mocked method?
|
All 624 screenshot tests passed for commit e9d2014 vs. |
…cript--tab-indicator
acdvorak
dismissed
kfranqueiro’s stale review
Unit test change is necessary for Istanbul, and Matt LGTM'd
|
All 624 screenshot tests passed for commit f2a72b9 vs. |
Refs #4225