feat(autocomplete): add custom sort option #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the datepicker to also use the document selector like the timepicker
Allow Timepicker to be used with an element instead of a selector string
|
I've added docs for this: At this point the PR is ready for review but I might just keep it in draft mode until we're actively working on 2.0. That or we could merge it to a 2.0 branch. |
ChildishGiant
changed the title
Update documentation to reflect the way picker containers
Update datepicker & timepicker "container" option to allow being specified the same way
build(deps): 🔒 fix many security issues,
…-off Autocomplete off for docs
…-tests Fix ERR_FILE_NOT_FOUND when running npm test
build(deps): update deps and fix deprecation warning in sass files
…n-message Copy text without creating textarea and use single container for copy success message
|
Rebased onto master |
…adme docs: edit README
feat(datepicker): add possibility for a format function to Datepicker
* improving ToC * updating labels section * mention convention commit format in PR guide * removed translations section
…uting-docs Improving CONTRIBUTING document
…grade-grunt-contrib-jasmine test: upgrade grunt-contrib-jasmine to upgrade puppeteer and set version of jasmine
|
It seems there is a commitlint violation. |
BREAKING CHANGE: renamed sortFunction to compareFunction
ChildishGiant
force-pushed
the
custom-sort
branch
from
e4c7623 to
eedcc3d
Compare
|
Not sure what's going on here, I'm gonna just close this and remake the commit. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also renamed sortFunction to compareFunction (Closes #115)
Proposed changes
Currently you can specify a custom "sortFunction" but this only controls which element wins in a 1v1 matchup, not how the matchups are made (Currently just uses array.sort). Adding this would allow end users to use libraries such as fuse.js to do more complex sorting and make results more accurate.
Types of changes
Checklist: