Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon tabs #370

Closed
wants to merge 2 commits into from
Closed

Icon tabs #370

wants to merge 2 commits into from

Conversation

danice
Copy link

@danice danice commented May 18, 2023

Proposed changes

Example of tabs with icons + fix for a small issue of tab not being selected when the icon was clicked.

Screenshots (if appropriate) or codepen:

Types of changes

  • Bug fix (non-breaking change which fixes an issue).

  • New feature (non-breaking change which adds functionality).

  • Breaking change (fix or feature that would cause existing functionality to change).

  • I have read the CONTRIBUTING document.

  • My commit messages follows the conventional commit format

  • My change requires a change to the documentation, and updated it accordingly.

  • I have added tests to cover my changes.

  • All new and existing tests passed.

@wuda-io wuda-io changed the base branch from main to v2-dev May 30, 2023 09:59
@gselderslaghs
Copy link

gselderslaghs commented Nov 22, 2024

I've reviewed this feature as it would be a great enhancement towards Materialize
The only thing I came up to is this PR is missing the necessarily styling to work in combination with the tab labels

Since I have experimented with this PR, I came onto this solution:

  • Adding tabs-vertical or tabs-horizontal class to the tabs wrapper
  • Apply the following SCSS:
&.tabs-vertical {
    height: 64px;
    .tab {
      height: 64px;

      a {
        display: flex;
        flex-direction: column;
        padding-top: 10px;
      }

      span {
        height: 24px;
        line-height: 20px;
      }
    }
  }

  &.tabs-horizontal .tab {
    i.material-icons {
      position: relative;
      top: -2px;
      vertical-align: middle;
    }
  }

@danice can you update the PR with the latest version of v2-dev and apply the styling for vertical/horizontal styling?
The documentation should also be updated since it was removed from the repository

@danice
Copy link
Author

danice commented Nov 23, 2024

I'm glad someone is interested in this PR more than 1 year later!
I have included your css changes and with some adjustments looks like this;

imagen

I'm preparing a new PR, and then I will close this one.

@danice
Copy link
Author

danice commented Nov 24, 2024

Moving to #533 and closing.

@danice danice closed this Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants