Tabs with Icons #533
Merged
Tabs with Icons #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuda-io
approved these changes
Nov 24, 2024
|
Thanks for the new PR! Sorry, there were some changes in the old PR, so I could not easily merge it without affecting other code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adding the options to include icons to tabs.
Changes:
Note:
Following M3 Tabs specification, tabs appear vertically-centered by default.
Screenshots (if appropriate) or codepen:
Types of changes
Bug fix (non-breaking change which fixes an issue).
New feature (non-breaking change which adds functionality).
Breaking change (fix or feature that would cause existing functionality to change).
I have read the CONTRIBUTING document.
My commit messages follows the conventional commit format
My change requires a change to the documentation, and updated it accordingly. (Done)
I have added tests to cover my changes.
All new and existing tests passed.