Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the pronunciation from the response #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

astromme
Copy link

The server response includes pronunciation (e.g. pinyin for chinese) which should be exposed in the library's response.

@coveralls
Copy link

coveralls commented Mar 20, 2018

Coverage Status

Coverage increased (+1.7%) to 92.647% when pulling fc2ace1 on astromme:master into 777d7db on matheuss:master.

@codecov-io
Copy link

codecov-io commented Mar 20, 2018

Codecov Report

Merging #61 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   92.42%   92.64%   +0.22%     
==========================================
  Files           2        2              
  Lines          66       68       +2     
==========================================
+ Hits           61       63       +2     
  Misses          5        5
Impacted Files Coverage Δ
index.js 90.56% <100%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 777d7db...fc2ace1. Read the comment docs.

Copy link
Contributor

@jacksteamdev jacksteamdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Props for adding a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants