Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignnamepattern #1003

Merged
merged 4 commits into from
Nov 14, 2020
Merged

Assignnamepattern #1003

merged 4 commits into from
Nov 14, 2020

Conversation

mmatera
Copy link
Contributor

@mmatera mmatera commented Nov 14, 2020

Here are the improvements in #995 that are currently functional.

@mmatera mmatera requested a review from rocky November 14, 2020 15:59
Copy link
Member

@rocky rocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at and as far a the code looks, I just see good stuff and improvements.

No tests as yet. I suppose that can come later.

Will wait for CI to finish (or maybe it has by now).

For this PR and the one for sessions it would be good to update CHANGES.rst.

You are probably in a better position to update this than I am, but if you don't have time to do I'll do this as part of the release process.

And thanks for moving the ball forward in being able to import external WL project code.

@rocky
Copy link
Member

rocky commented Nov 14, 2020

With respect to the other PR on sessions, https://github.com/mathics/Mathics/wiki/Calling-Mathics-library-from-within-Python-code should be updated, right?

@rocky rocky merged commit 8bda517 into master Nov 14, 2020
@mmatera
Copy link
Contributor Author

mmatera commented Nov 14, 2020

I added the changes to CHANGE.rst. I guess that MathicsSession is something that we can include, even if the implementation is very primitive.
Later I can modify the wiki.

rocky added a commit that referenced this pull request Nov 14, 2020
@rocky
Copy link
Member

rocky commented Nov 14, 2020

@mmatera thanks. It is all merged now.

@GarkGarcia I am starting the release process. Please no changes to master until this is done.

In this period I will be committing to master which is normally not advised and maybe in the future we can change this.

Here it will simplify things a little. As is happening right now there are some merges (of comment-like code) that are occuring before the CI process finishes. And there may be more of this. However before the final tagging I'll wait for the 30-minute or so CI process to finish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants