Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for function calls within brace validation lists #86

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Allow for function calls within brace validation lists #86

merged 2 commits into from
Jul 19, 2024

Conversation

apozharski
Copy link
Contributor

resolves #85

@apozharski apozharski mentioned this pull request Jul 17, 2024
Closed
@dklilley dklilley self-assigned this Jul 17, 2024
@dklilley dklilley self-requested a review July 17, 2024 16:53
@dklilley
Copy link
Member

Thank you for making this change! I will take a look this week!

@nothans nothans added the CLA required Requires the signing of a Contributor License Agreement label Jul 17, 2024
@nothans
Copy link
Member

nothans commented Jul 17, 2024

Can you contact me about signing the CLA? Thank you for the contribution!

@apozharski
Copy link
Contributor Author

Can you contact me about signing the CLA? Thank you for the contribution!

@nothans I have sent you an email to the address on your github profile.

@apozharski apozharski mentioned this pull request Jul 18, 2024
Merged
@nothans nothans added CLA signed Indicates that the requester has signed the Contributor License Agreement and removed CLA required Requires the signing of a Contributor License Agreement labels Jul 18, 2024
@nothans
Copy link
Member

nothans commented Jul 18, 2024

The CLA has been signed. Thanks again.

@apozharski apozharski mentioned this pull request Jul 18, 2024
Merged
@dklilley
Copy link
Member

@apozharski , it looks like one of the snap tests needs to be updated due to these changes. Can you confirm that the failure is expected, and update the snap tests (see details in test/README.md)?

@apozharski
Copy link
Contributor Author

Yep, the new failure makes sense. I have updated the .snap (and the README as it was missing some details on a libxml2-utils dependency).

@apozharski apozharski mentioned this pull request Jul 19, 2024
Closed
@dklilley dklilley merged commit f12f1af into mathworks:master Jul 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dklilley dklilley dklilley approved these changes

Assignees

@dklilley dklilley

Labels
CLA signed Indicates that the requester has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validation function parsing not correct for validation functions with arguments
3 participants
@apozharski @dklilley @nothans