Fix broken attribute parsing in classdef. #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Latest push also supports proper parsing of metaclasses on the right hand side of the assignments e.g. This is currently only supported in attributes however I have opened #89 to generalize this to the top level. |
apozharski
force-pushed
the
better-classdef
branch
from
203ff2b
to
8e8d725
Compare
apozharski
changed the title
apozharski
force-pushed
the
better-classdef
branch
from
45b229d
to
7de6a0c
Compare
dklilley
added
the
CLA signed
dklilley
approved these changes
Jul 19, 2024
|
Thanks for making these changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #87
This still is not entirely correct however it fails only in the case where the end of the attribute block is separated by newline (and line continuation) from the
ClassName. Making a fully correct TextMate compatible grammar seems impossible due to the ability to arbitrarily place line continuations, however this is a closer approximation and improves the usability of this grammar for further machine interaction e.g. https://github.com/sphinx-contrib/matlabdomainNote: #86 must go in first.