Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change diverged flags back to Geth's convention (POS-602) #451

Merged
merged 12 commits into from
Jul 14, 2022
Merged

Change diverged flags back to Geth's convention (POS-602) #451

merged 12 commits into from
Jul 14, 2022

Conversation

pratikspatil024
Copy link
Member

@pratikspatil024 pratikspatil024 commented Jul 11, 2022 •
edited by manav2401
Loading

This PR does the following things:

  1. Changes the following flags:
name -> identity
no-snapshot -> snapshot=false / snapshot=true
http.modules -> http.api
ws.modules -> ws.api
  1. Fixes the bug where items are appended to the SliceString instead of overwriting it.
  2. Adds a Default field to the SliceStringFlag.
  3. Adds separate flags for corsdomain and vhosts for http, ws, and graphql.
http.corsdomain
http.vhosts
ws.corsdomain
ws.vhosts
graphql.corsdomain
graphql.vhosts

POS-602

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022 •
edited
Loading

Codecov Report

Merging #451 (815d424) into develop (f28f384) will increase coverage by 0.06%.
The diff coverage is 34.78%.

@@             Coverage Diff             @@
##           develop     #451      +/-   ##
===========================================
+ Coverage    56.30%   56.36%   +0.06%     
===========================================
  Files          597      600       +3     
  Lines        69014    69037      +23     
===========================================
+ Hits         38855    38912      +57     
+ Misses       26812    26798      -14     
+ Partials      3347     3327      -20
Impacted Files Coverage Δ
internal/cli/server/flags.go 0.00% <0.00%> (ø)
internal/cli/server/server.go 25.14% <0.00%> (ø)
internal/cli/server/config.go 72.72% <88.88%> (+0.46%) ⬆️
p2p/discover/v4_udp.go 72.75% <0.00%> (-4.35%) ⬇️
core/state/trie_prefetcher.go 74.80% <0.00%> (-3.82%) ⬇️
p2p/discover/table.go 82.48% <0.00%> (-1.83%) ⬇️
rpc/client.go 83.72% <0.00%> (-1.17%) ⬇️
p2p/simulations/mocker.go 30.00% <0.00%> (-1.12%) ⬇️
les/vflux/server/prioritypool.go 81.25% <0.00%> (-0.94%) ⬇️
trie/trie.go 76.47% <0.00%> (-0.74%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f28f384...815d424. Read the comment docs.

@pratikspatil024 pratikspatil024 marked this pull request as ready for review July 12, 2022 10:39
manav2401
manav2401 approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@manav2401 manav2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cffls
cffls approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@cffls cffls left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Notice that integration test failed. This is because the flags are changed, so bor couldn't correctly launch in CI. After this is merged, we will need to change start.sh in matic-cli here: https://github.com/maticnetwork/matic-cli/blob/v0.3.0-dev/src/setup/devnet/templates/docker/docker-bor-start.sh.njk

@pratikspatil024 pratikspatil024 mentioned this pull request Jul 13, 2022
Merged
@pratikspatil024 pratikspatil024 merged commit 3df1d6f into develop Jul 14, 2022
cffls pushed a commit to cffls/bor that referenced this pull request Jul 30, 2022
@pratikspatil024 @cffls
Change diverged flags back to Geth's convention (POS-602) (maticnetwo…
f539818 
…rk#451)

* changed name -> identity

* changed no-snapshot -> snapchot=true/false

* changed jsonrpc.corsdomain -> http.corsdomain

* changed jsonrpc.vhosts -> http.vhosts

* changed http/ws.modules to http/ws.api

* updated readme

* updated config_test

* make docs

* handelling string array flag, overwrite insted of append

* added 'Default' to SliceStringFlag

* added separate flags for corsdomain and vhosts for http, ws, graphql

* modified tests
cffls pushed a commit that referenced this pull request Aug 1, 2022
@pratikspatil024 @cffls
Change diverged flags back to Geth's convention (POS-602) (#451)
bc2d882 
* changed name -> identity

* changed no-snapshot -> snapchot=true/false

* changed jsonrpc.corsdomain -> http.corsdomain

* changed jsonrpc.vhosts -> http.vhosts

* changed http/ws.modules to http/ws.api

* updated readme

* updated config_test

* make docs

* handelling string array flag, overwrite insted of append

* added 'Default' to SliceStringFlag

* added separate flags for corsdomain and vhosts for http, ws, graphql

* modified tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JekaMas JekaMas JekaMas approved these changes

@manav2401 manav2401 manav2401 approved these changes

@cffls cffls cffls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pratikspatil024 @codecov-commenter @JekaMas @manav2401 @cffls