Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated changed flags (bor/pull/451) #46

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Updated changed flags (bor/pull/451) #46

merged 2 commits into from
Jul 14, 2022

Conversation

pratikspatil024
Copy link
Member

This PR updates the flags that are going to change in this PR (bor#451).

POS-634

manav2401
manav2401 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@manav2401 manav2401 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note: We can skip the graphql vhosts and corsdomain flag as we aren't enabling it (or using it at all).

cffls
cffls approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@cffls cffls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pratikspatil024
Copy link
Member Author

LGTM.

Note: We can skip the graphql vhosts and corsdomain flag as we aren't enabling it (or using it at all).

Done.

@temaniarpit27 temaniarpit27 merged commit 2ed88f1 into maticnetwork:v0.3.0-dev Jul 14, 2022
@pratikspatil024 pratikspatil024 mentioned this pull request Jul 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manav2401 manav2401 manav2401 approved these changes

@cffls cffls cffls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pratikspatil024 @manav2401 @cffls @temaniarpit27