Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop #1223

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Merge develop #1223

merged 2 commits into from
Jan 10, 2025

Conversation

Raneet10
Copy link
Member

Description

PR to merge develop.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai or amoy
  • I have created new e2e tests into express-cli

@Raneet10 Raneet10 requested a review from a team January 10, 2025 06:37
@Raneet10 Raneet10 merged commit e5299bd into v1.1.0-new-span-msg Jan 10, 2025
13 checks passed
Raneet10 added a commit that referenced this pull request Jan 16, 2025
* New propose span msg

* helper: temporarily set antevortaHeight for testing

* bor: fix nil author clause

* bor: fix TestProposeSpanOne and TestGetNextSpanSeed

* bor: avoid nil ptr deref

* Add support for new msg propose span in cli and rest

* Enable all hardforks at zero height

* helper: temporarily add non-zero hf heights for testing

* bor: fix handler

* When proposing span query height from the node

* Enable all forks on zero height

* Add temporary commands to test malicious cases

* Add temporary commands to test malicious cases

* Let the bridge propose only the first two spans

* Dont enable antevorta from zero height

* Restrict new msg pre-hardfork

* set non-zero height for antevorta

* Add debug logging

* Lower enable fork height

* Clean up

* Cleanup

* Fix lint

* Fix comments

* fix: nil logger

* Unify how we check for Jorvik height

* Allow new and old span propose messages only at correct heights in PostHandle

* Propose span only if proposedSpanID-2 is finished

* Propose span only if proposedSpanID-2 is finished

* rm: useless tests (#1223)

Co-authored-by: marcello33 <marcelloardizzone@hotmail.it>

* bor,bridge,helper: rename antevorta to danelaw fork

* bor,bridge: rebase and renaming to danelaw

* Fix rollback command (#1217)

* cmd: fix rollback

* cmd: init rootmultistore from given db

* cmd: disable rollback

* align go deps

* cmd: renable rollback

* Rename Antevorta to Danelaw in error logs

* helper: set danelaw height for amoy

* Fixes for profiles, removing some unecessary postinst file, update to prerm, and postrm.profile

---------

Co-authored-by: Angel Valkov <avalkov@polygon.technology>
Co-authored-by: marcello33 <marcelloardizzone@hotmail.it>
Co-authored-by: Daniel Jones <djones@polygon.technology>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants