Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge v1.1.0-new-span-msg #1226

Merged
merged 37 commits into from
Jan 16, 2025
Merged

Merge v1.1.0-new-span-msg #1226

merged 37 commits into from
Jan 16, 2025

Conversation

Raneet10
Copy link
Member

Description

This PR includes fixes related to Danelaw HF and rollback command.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai or amoy
  • I have created new e2e tests into express-cli

avalkov and others added 30 commits December 6, 2024 13:46
@avalkov
New propose span msg
7a5ae0f
@Raneet10
helper: temporarily set antevortaHeight for testing
2c517e3
@Raneet10
bor: fix nil author clause
34563f9
@Raneet10
bor: fix TestProposeSpanOne and TestGetNextSpanSeed
e1d5a3f
@Raneet10
bor: avoid nil ptr deref
87ef859
@avalkov
Add support for new msg propose span in cli and rest
7c76ee2
@avalkov
Enable all hardforks at zero height
4630b53
@Raneet10
helper: temporarily add non-zero hf heights for testing
695f3b8
@Raneet10
bor: fix handler
fe2f618
@avalkov
When proposing span query height from the node
0f90239
@avalkov
Enable all forks on zero height
eced431
@avalkov
Add temporary commands to test malicious cases
21cd612
@avalkov
Add temporary commands to test malicious cases
c22c680
@avalkov
Let the bridge propose only the first two spans
652b4da
@avalkov
Dont enable antevorta from zero height
61d3f00
@avalkov
Restrict new msg pre-hardfork
fe80a4f
@avalkov
set non-zero height for antevorta
221e037
@avalkov
Add debug logging
9323f1e
@avalkov
Lower enable fork height
35b725d
@avalkov
Clean up
76ac6d3
@avalkov
Cleanup
3024891
@avalkov
Fix lint
14251ca
@avalkov
Fix comments
15a8f62
@avalkov
Merge pull request #1212 from maticnetwork/v1.1.0-new-span-msg-zero-h…
bafc9e6 
…eight-ready

V1.1.0 new span msg zero height ready
@marcello33
fix: nil logger
5c353b1
@avalkov
Unify how we check for Jorvik height
37daf72
@avalkov
Allow new and old span propose messages only at correct heights in Po…
1a51ea2 
…stHandle
@avalkov
Propose span only if proposedSpanID-2 is finished
8df4709
@avalkov
Propose span only if proposedSpanID-2 is finished
600ecc5
@Raneet10 @marcello33
rm: useless tests (#1223)
e5299bd 
Co-authored-by: marcello33 <marcelloardizzone@hotmail.it>
@Raneet10 Raneet10 requested a review from a team January 16, 2025 11:27
@Raneet10 Raneet10 merged commit 58bd98e into v1.1.0-beta-candidate Jan 16, 2025
7 checks passed
@Raneet10 Raneet10 deleted the v1.1.0-new-span-msg branch January 16, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avalkov avalkov avalkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Raneet10 @avalkov @marcello33 @djpolygon