Improvements on "Getting Started Part II" #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -74,18 +84,18 @@ Reports and metrics should always be served through API class methods. The repor | |||
| } | |||
|
|
|||
| <div markdown="1" class="alert alert-warning"> | |||
| **Analytics Parameters** | |||
| **API parameters** | |||
There was a problem hiding this comment.
"Analytics Parameters" felt very vague to me here (from a noob POV), suggestions welcome if you disagree with the edit.
|
If you are wondering why most code comments are edited, it's because they didn't fit on screen (they were wrapped to a new line). |
| { | ||
| $files[] = 'plugins/MyPlugin/javascripts/plugin.js'; | ||
| } | ||
| } |
There was a problem hiding this comment.
(the console command didn't exist anymore)
mattab
pushed a commit
that referenced
this pull request
Oct 13, 2014
Improvements on "Getting Started Part II"
|
👍 good to see you test the commands and review test the code! |
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the plan to review the documentation: #22
Feel free to comment inline.
You can show the diff as rendered Markdown in Github => it should help review the changes.