Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review each guide and improve the content and structure #22

Closed
33 tasks done
mattab opened this issue Oct 7, 2014 · 7 comments
Closed
33 tasks done

Review each guide and improve the content and structure #22

mattab opened this issue Oct 7, 2014 · 7 comments
Assignees
Milestone

Comments

@mattab
Copy link
Member

mattab commented Oct 7, 2014

The goal of this project is a medium term goal that you review each page of the Developer website. The goal is to make the documentation from OK quality to good or even very good (!) when possible.

Project description:

See also the related issue in piwik/piwik

Assigned to at least @mnapoli and @mattab who will review content of each page

@mattab mattab added this to the 1.0.0 release milestone Oct 7, 2014
mnapoli added a commit that referenced this issue Nov 22, 2014
mnapoli added a commit that referenced this issue Nov 23, 2014
mnapoli added a commit that referenced this issue Nov 23, 2014
This was referenced Nov 23, 2014
mnapoli added a commit that referenced this issue Nov 26, 2014
mnapoli added a commit that referenced this issue Nov 26, 2014
@mattab
Copy link
Member Author

mattab commented Nov 26, 2014

Here is some feedback after your nice PR was merged @mnapoli

@mnapoli
Copy link
Contributor

mnapoli commented Nov 26, 2014

Definitely agree, but it doesn't seem to be easily doable because it's the generated documentation: the name is the name of the PHP class. I don't see how to do that without changing a lot of things :(

@mnapoli
Copy link
Contributor

mnapoli commented Nov 26, 2014

The website might be slow when the cache is cleared: to build the left menu (and keep the code simple) we have to be read all guides of the category, which is quite fast (even though it's theoretically inefficient) but in some case it includes a remote URL so it takes a bit of time. I went that way because online everything is cached so it's not an issue once a page is viewed (and it makes the whole code much easier).

We could add a warmup after clearing caches if that's too critical.

@mattab
Copy link
Member Author

mattab commented Nov 27, 2014

We could add a warmup after clearing caches if that's too critical.

it's not critical, it's pretty fast for now, but if warmup is very low effort for you then +1 ;-)

mattab pushed a commit that referenced this issue Dec 9, 2014
#22 #44 Article reviews and migration
mnapoli added a commit that referenced this issue Dec 12, 2014
mnapoli added a commit that referenced this issue Dec 12, 2014
mattab pushed a commit that referenced this issue Dec 12, 2014
mattab pushed a commit that referenced this issue Dec 12, 2014
#22 Reviewed "Distributing Your Plugin"
mnapoli added a commit that referenced this issue Dec 17, 2014
mnapoli added a commit that referenced this issue Dec 17, 2014
mnapoli added a commit that referenced this issue Jan 12, 2015
mattab pushed a commit that referenced this issue Jan 14, 2015
#22 Reviewed Piwik Reporting HTTP API
mnapoli added a commit that referenced this issue Jan 26, 2015
mnapoli added a commit that referenced this issue Jan 29, 2015
mnapoli added a commit that referenced this issue Jan 30, 2015
mnapoli added a commit that referenced this issue Feb 6, 2015
@mnapoli
Copy link
Contributor

mnapoli commented Feb 15, 2015

Once #70 is merged this task is finished!

@mnapoli
Copy link
Contributor

mnapoli commented Feb 16, 2015

Done!

@mnapoli mnapoli closed this as completed Feb 16, 2015
@mattab
Copy link
Member Author

mattab commented Feb 17, 2015

Plugin developers now have a great resource to learn from, and @piwik/core-team will keep iterating and updating the guides as the platform evolves.

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants