Reviewed Security In Piwik #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
|
|
||
| $rows = Db::query($sql, array($idSite)); | ||
| $rows = Db::query($sql, array($idSite)); | ||
| ``` | ||
|
|
||
| There is a limit to the number of placeholders you can use. If you need to use more placeholders than the limit allows, you may have to concatenate the parameters directly. Make sure these parameters are obtained from a trusted source (such as from another query). |
There was a problem hiding this comment.
This paragraph and the one below, I cannot understand it. Could we remove them?
+1 - this part of the guide was really old and outdated... Feel free to merge after those! |
|
All done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #22
I'm opening this as a PR because it depends on #34 to be merged (else code blocks will not work).
Not many changes but the diff seems to be a bit messed up.
Regarding Preventing Direct Access, is that common that plugins provide files that execute something? Because if that's not common/shoudn't happen, then I'd rather replace that part with something like this:
E.g. in PSR-1 there's this rule:
I'd say code causing side-effect should not exist in plugins. Does that makes sense?