Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#22 Reviewed "Piwik on the Command Line" #52

Merged
merged 1 commit into from
Dec 16, 2014
Merged

#22 Reviewed "Piwik on the Command Line" #52

merged 1 commit into from
Dec 16, 2014

Conversation

mnapoli
Copy link
Contributor

@mnapoli mnapoli commented Dec 15, 2014

#22

Previously, in the menu:

  • User Interface
    • Pages
    • Menus
  • Piwik on the Command Line

I've renamed that to:

  • Web Interface
  • Command Line Interface

I think this is more consistent and explicit: Piwik offers several interfaces (web, CLI, HTTP API…), plugins can code extensions to those interfaces.

We could even extend that to the HTTP Reporting API guides?

  • Web Interface (controllers, views, pages, menus, …)
  • HTTP API (Piwik APIs, Reporting API…)
  • Command Line Interface

That conforts me that the current MVC guide with sub-guides:

  • Models (API classes)
  • Controllers
  • Views

should no longer exist. "Controllers" and "Views" duplicates the "Pages" guide for example. Same for "Models (API classes)" with duplicates/confuses with the "Piwik's Reporting API" guide.

Anyway, this is for another pull request…

…ine Interface" to be consistent with "Web Interface"
@mattab
Copy link
Member

mattab commented Dec 16, 2014

 I think this is more consistent and explicit:

agree, small change but much clearer

We could even extend that to the HTTP Reporting API guides?

👍

mattab pushed a commit that referenced this pull request Dec 16, 2014
#22 Reviewed "Piwik on the Command Line"
@mattab mattab merged commit e43d144 into master Dec 16, 2014
@mnapoli mnapoli deleted the review/cli branch December 16, 2014 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants