Reviewed "Automated tests" #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
|
|
||
| _Note: All test files must be put in a **tests** directory located in the root directory of your plugin and every test you write should have the `@group` set to the name of your plugin (for example, `@group MyPlugin`)._ | ||
| *Note: All test files must be put in a `Test/` directory located in the root directory of your plugin and every test you write should have the `@group` set to the name of your plugin (for example, `@group MyPlugin`).* |
There was a problem hiding this comment.
is it still true that
every test you write should have the `@group` set to the name of your plugin (for example, `@group MyPlugin`).
maybe this can be removed ?
|
Would it make sense to split the guide about System tests in one smaller guide, and also move Screenshot test doc in one small guide? |
|
Nice one! though the guide feels too long (took me much concentration to read it ;) |
|
Fixed all the comments, going to merge. I'll have a look at splitting the guide in #43 |
|
Guide splitted in the PR #43! It look soooo much nicer :) |
mnapoli
added a commit
that referenced
this pull request
Nov 26, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #22. Depends on #34 too, merge #34 before this one.
The guide was still talking about:
I've renamed "integration tests" with "system tests" (as that's what I understood) and added a new "integration tests" which is basically old unit tests that used the database or the server.
Also just to be sure, I've seen plugins use
tests/andTest/as a subdirectory. I don't know which one is the best, but I've edited the guide to be consistent (I've usedTest/as I think that's the one I've seen the most in plugins, and that's the one which makes sense with autoloading).