-
Notifications
You must be signed in to change notification settings - Fork 22
Codecov is not showing the latest commits on main
.
#155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Bug
Something isn't working
Tests
Upstream issue
Needs a fix in one of the napari-matplotlib dependencies
Comments
(@ruaridhg we spoke about this IRL yesterday) |
This was referenced Jun 12, 2023
Merged
I think what's happening is:
So it seems like one solution is to stop the merge queue CI uploading coverage? |
clabby
added a commit
to op-rs/kona
that referenced
this issue
Jun 11, 2024
## Overview Changes the codecov job to not run in the merge queue. See: matplotlib/napari-matplotlib#155
github-merge-queue bot
pushed a commit
to op-rs/kona
that referenced
this issue
Jun 11, 2024
## Overview Changes the codecov job to not run in the merge queue. See: matplotlib/napari-matplotlib#155
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
Something isn't working
Tests
Upstream issue
Needs a fix in one of the napari-matplotlib dependencies
Relatively minor, and I think it's something to do with the merge queue's autobranches.
The codecov landing page for this project should show the coverage at the "latest" commit on
main
. Which it claims is 9598eebHowever, that was the middle of last week. There don't seem to be any relevant changes after or around this commit in our history (the next PR to be merged into
main
was #146 which doesn't touch the coverage or the ci).Note that all commits' builds on
main
actually have sent coverage reports to codecov. They are coming from the merge queue's auto-generated branches and when the build reruns onmain
, it seems somehow that thegh-readonly-queue/
branch is given precedence.Not sure if this can be fixed with a setting in codecov. Possibly we could skip coverage upload by hacking our CI yml with something like:
For the coverage step. Assuming that it reruns the build as on
main
.Unsure if related, but (since I'm digging in the codecov uploads) we have encountered codecov/3954 a few times. They recommend using a codecov upload token even if the repo is public.
The text was updated successfully, but these errors were encountered: