Skip to content

Add test that figure is updated when layer change for HistogramWidget #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 1, 2023

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Jun 1, 2023

This is a MVP for #7, applied to the histogram widget. If it's approved and merged, I'll roll out the same approach to other widgets in a follow up PR.

@dstansby dstansby requested a review from ruaridhg June 1, 2023 13:11
@dstansby dstansby force-pushed the layer-changed-test branch from 31e0fb3 to 9f388bb Compare June 1, 2023 13:16
@dstansby dstansby marked this pull request as ready for review June 1, 2023 13:20
Copy link
Collaborator

@ruaridhg ruaridhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@ruaridhg ruaridhg added this pull request to the merge queue Jun 1, 2023
Merged via the queue into matplotlib:main with commit 7b018f5 Jun 1, 2023
@dstansby dstansby deleted the layer-changed-test branch June 1, 2023 14:11
@dstansby dstansby added the Tests label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants