-
Notifications
You must be signed in to change notification settings - Fork 22
Don't read full cube into mem for histogramming #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
38fbccd
Don't read full cube into mem for histogramming
dstansby 1aa3efd
Actually don't read all bins into memory...
dstansby 804934c
Read data into memory
dstansby e84958d
Remove print statements
dstansby 0523d28
Add changelog
dstansby File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -33,14 +33,21 @@ def draw(self) -> None: | |||
Clear the axes and histogram the currently selected layer/slice. | ||||
""" | ||||
layer = self.layers[0] | ||||
bins = np.linspace(np.min(layer.data), np.max(layer.data), 100) | ||||
print(layer.data.shape) | ||||
|
||||
if layer.data.ndim - layer.rgb == 3: | ||||
# 3D data, can be single channel or RGB | ||||
data = layer.data[self.current_z] | ||||
self.axes.set_title(f"z={self.current_z}") | ||||
else: | ||||
data = layer.data | ||||
# Read data into memory if it's a dask array | ||||
data = np.asarray(data) | ||||
|
||||
# Important to calculate bins after slicing 3D data, to avoid reading | ||||
# whole cube into memory. | ||||
bins = np.linspace(np.min(data), np.max(data), 100) | ||||
samcunliffe marked this conversation as resolved.
Show resolved
Hide resolved
|
||||
print(bins) | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Ditto. |
||||
|
||||
if layer.rgb: | ||||
# Histogram RGB channels independently | ||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug output? To be removed?