mitmproxy: let the callback addon modify response data #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not currently used in tests. With tests.
kegsay
commented
Jul 4, 2024
| func (cd CallbackData) String() string { | ||
| return fmt.Sprintf("%s %s (token=%s) req_len=%d => HTTP %v", cd.Method, cd.URL, cd.AccessToken, len(cd.RequestBody), cd.ResponseCode) | ||
| } | ||
|
|
||
| // NewCallbackServer runs a local HTTP server that can read callbacks from mitmproxy. | ||
| // Returns the URL of the callback server for use with WithMITMOptions, along with a close function | ||
| // which should be called when the test finishes to shut down the HTTP server. | ||
| func NewCallbackServer(t *testing.T, hostnameRunningComplement string, cb func(CallbackData)) (callbackURL string, close func()) { | ||
| func NewCallbackServer(t *testing.T, hostnameRunningComplement string, cb func(CallbackData) *CallbackResponse) (callbackURL string, close func()) { |
There was a problem hiding this comment.
This is the important bit as it changes the API for the callback server to return an optional CallbackResponse.
andybalaam
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not currently used in tests. With integreation tests.
The next step is to allow the
callbackaddon to implement the last remaining feature of thestatus_codeaddon, which is the ability to block requests from reaching the server. Currently, the hook incallbackis in the "response" flow, which means it has already reached the server. This will require some rejigging to call the callback server earlier if it has been configured that way.Once that is done, the
status_codeaddon can be removed andcallbackcan be used everywhere.Related:
status_codeis removed.callbackaddon involved.