Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mitm/callback options more composable #88

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Make mitm/callback options more composable #88

merged 3 commits into from
Jun 20, 2024

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Jun 18, 2024

It's slightly better but not perfect yet because:

  • you can't enable both blocking and callbacks, then drop the blocking but not the callbacks. TestToDeviceMessagesAreProcessedInOrder needs this to block /sync for a while then unblock it, and throughout it wants to listen for /sync responses.
  • You can't listen for >1 path with a MITMConfiguration. We don't have any tests which want this currently though.
  • You can't do funky logic to determine if you should block a request (e.g only block if the request has these fields set). Again, no tests need this currently.

Partly addresses #68

@kegsay kegsay requested a review from andybalaam June 18, 2024 15:58
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, much nicer.

@kegsay kegsay merged commit 7041e29 into main Jun 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants