Add heroes to the room summary #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilalexander
approved these changes
Apr 26, 2022
| ctx context.Context, txn *sql.Tx, roomID, userID string, memberships []string, | ||
| ) (heroes []string, err error) { | ||
| stmtSQL := strings.Replace(selectHeroesSQL, "($3)", sqlutil.QueryVariadicOffset(len(memberships), 2), 1) | ||
| stmt, err := s.db.Prepare(stmtSQL) |
There was a problem hiding this comment.
You'll need to close this too, otherwise the prepared statements leak.
| type membershipsStatements struct { | ||
| db *sql.DB | ||
| upsertMembershipStmt *sql.Stmt | ||
| selectMembershipCountStmt *sql.Stmt | ||
| selectHeroesStmt *sql.Stmt |
There was a problem hiding this comment.
If we have to prepare to do variadics, there isn't much point in preparing it up front. Normally I just leave these commented out so that it's obvious there's something but we don't waste the effort preparing a statement we never use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs matrix-org/sytest#1246, as otherwise the tests will flake.