Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Join room synced for room summary tests #1246

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Join room synced for room summary tests #1246

merged 1 commit into from
Apr 26, 2022

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Apr 25, 2022

This ensures the user is actually joined to the room and doesn't flake on Dendrite.

@S7evinK S7evinK requested a review from a team as a code owner April 25, 2022 17:43
@S7evinK S7evinK mentioned this pull request Apr 25, 2022
Merged
DMRobertson
DMRobertson approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy if CI is.

(Maybe we should just get rid of matrix_join_room_synced Edit: matrix_join_room altogether?)

@S7evinK
Copy link
Contributor Author

S7evinK commented Apr 26, 2022

I'd be in favor of doing so, but not sure if it actually makes sense to have both. I'll create an issue for this.

@S7evinK S7evinK mentioned this pull request Apr 26, 2022
Closed
@S7evinK S7evinK merged commit a46b05a into develop Apr 26, 2022
@S7evinK S7evinK deleted the s7evink/roomsummary branch April 26, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMRobertson DMRobertson DMRobertson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@S7evinK @DMRobertson