Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of non-synced room joins #1247

Closed
S7evinK opened this issue Apr 26, 2022 · 2 comments
Closed

Get rid of non-synced room joins #1247

S7evinK opened this issue Apr 26, 2022 · 2 comments
Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@S7evinK
Copy link
Contributor

S7evinK commented Apr 26, 2022

As mentioned by @DMRobertson in #1246 (review), it might make sense to remove the non synced version of matrix_join_room (and most likely other non synced actions, like matrix_create_room etc.)

The reason: Dendrite often flakes due to it's async nature and events might not be persisted yet when hitting /sync or other endpoints.

I'm not sure if we can simply replace it or if the non-synced versions have their use cases.
@richvdh
Copy link
Member

richvdh commented Apr 28, 2022

Sounds good - we're not aware of any important usecase for the non-synced versions.

@S7evinK S7evinK mentioned this issue Apr 29, 2022
Merged
@H-Shay H-Shay added the T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. label Jun 1, 2022
richvdh pushed a commit that referenced this issue Jun 17, 2022
@S7evinK
Replace most non-synced actions (#1249)
4784b7e 
As explained in #1247, this PR changes most non-synced versions with the synced version.
matrix_create_room_synced now also returns the room alias.
@S7evinK
Copy link
Contributor Author

S7evinK commented Sep 20, 2022

Solved by #1249

@S7evinK S7evinK closed this as completed Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@richvdh @S7evinK @H-Shay