Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2689: Fix E2EE for guests #2689

Merged
merged 3 commits into from
Jul 29, 2020
Merged

MSC2689: Fix E2EE for guests #2689

merged 3 commits into from
Jul 29, 2020

Conversation

awesome-michael
Copy link
Contributor

@awesome-michael awesome-michael commented Jul 15, 2020 •
edited
Loading

Rendered

Extends #751

Signed-off-by: Michael Albert michael.albert@awesome-technologies.de

@uhoreg uhoreg changed the title Fix E2EE for guests MSC2689: Fix E2EE for guests Jul 15, 2020
@uhoreg
Copy link
Member

uhoreg commented Jul 15, 2020

Implemented in matrix-org/synapse#7314

uhoreg
uhoreg reviewed Jul 15, 2020
View reviewed changes
Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some typographical nit-picking

proposals/2689-fix-e2ee-for-guests.md Outdated Show resolved Hide resolved
proposals/2689-fix-e2ee-for-guests.md Outdated Show resolved Hide resolved
proposals/2689-fix-e2ee-for-guests.md Outdated Show resolved Hide resolved
@uhoreg uhoreg added proposal A matrix spec change proposal proposal-in-review labels Jul 15, 2020
@uhoreg
Copy link
Member

uhoreg commented Jul 16, 2020

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Jul 16, 2020 •
edited by ara4n
Loading

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

Concerns:

  • Needs sign-off

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added disposition-merge proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jul 16, 2020
@uhoreg uhoreg added the kind:maintenance MSC which clarifies/updates existing spec label Jul 16, 2020
@turt2live turt2live self-requested a review July 16, 2020 15:22
@turt2live
Copy link
Member

@mscbot concern Needs sign-off

@awesome-michael when you get the chance, please add the following to the PR description:

Signed-off-by: Your Name <email@example.org>

@turt2live
Copy link
Member

@mscbot resolve Needs sign-off

richvdh
richvdh approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

proposals/2689-fix-e2ee-for-guests.md Outdated Show resolved Hide resolved
@mscbot
Copy link
Collaborator

mscbot commented Jul 24, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jul 24, 2020
@awesome-michael @richvdh
Update proposals/2689-fix-e2ee-for-guests.md
78f3c3d 
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@mscbot
Copy link
Collaborator

mscbot commented Jul 29, 2020

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jul 29, 2020
@turt2live turt2live merged commit 5c0f999 into matrix-org:master Jul 29, 2020
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Jul 29, 2020
@wbamberg wbamberg mentioned this pull request Oct 7, 2020
Merged
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Oct 7, 2020
@turt2live
Copy link
Member

Spec PR: #2808

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Oct 7, 2020
@turt2live
Copy link
Member

Merged 🎉

@turt2live turt2live mentioned this pull request Oct 14, 2021
Closed
16 tasks
@S7evinK S7evinK mentioned this pull request Sep 28, 2023
Open
13 tasks
@matrixbot matrixbot mentioned this pull request Nov 1, 2024
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uhoreg uhoreg uhoreg left review comments

@richvdh richvdh richvdh approved these changes

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@awesome-michael @uhoreg @mscbot @turt2live @richvdh