[Spaces] Show spaces in left panel #4509 #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Initial yet naive algortihm for building the graph of rooms
MatrixSDK/Space/MXSpaceService.swift
Outdated
| @@ -51,6 +58,9 @@ public class MXSpaceService: NSObject { | |||
| private let processingQueue: DispatchQueue | |||
| private let completionQueue: DispatchQueue | |||
|
|
|||
| public private(set) var spaces: [MXSpace] = [] | |||
There was a problem hiding this comment.
Instead of a public property we should have like Android getters that returns space summaries, not directly MXSpace:
fun getSpaceSummaries(spaceSummaryQueryParams: SpaceSummaryQueryParams): List<RoomSummary>
fun getRootSpaceSummaries(): List<RoomSummary>
At the moment we do not have filtering but it will come later.
- Update after review - Compute parent rooms list for each room - Provide list of root spaces summaries
- `membersId` in `MXSpace` renamed as `otherMembersId`
- new API `MXSpaceService` for getting all ancestors of a room
- update after review
SBiOSoftWhare
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle element-hq/element-ios#4509, element-hq/element-ios#4495
Part of element-hq/element-ios#4503