Update Mutual Rooms (MSC2666) support #3381

ShadowJonathan · 2023-05-18T12:07:36Z

This updates the Mutual Rooms (MSC2666) implementation to match the latest version.

This also cleans and clears up the support for older versions of the MSC. The new version paginates, and so that support has been added too.

Checklist

Tests written for new code (and old code if feasible)
Linter and other CI checks pass
Sign-off given on the changes (see CONTRIBUTING.md)

Type: Task

Signed-off-by: Jonathan de Jong <jo@jo.wtf>

This change is marked as an internal change (Task), so will not be included in the changelog.

andybalaam · 2023-05-18T12:46:53Z

Thank you for your contribution! I'm looking at it now, but we have a (new since this was first implemented) requirement for 80% test coverage on any changes, so this will definitely need some tests before we can merge it.

ShadowJonathan · 2023-05-18T12:52:26Z

I'm going to try to figure out how to make tests for this, with example responses for each MSC version, and a pagination test.

andybalaam

Looks good, but needs tests. I suspect you could monkey-patch this.http.authedRequest with a mock, or maybe you can think of a better way.

src/client.ts

ShadowJonathan · 2023-05-19T10:30:44Z

@andybalaam fetch-mock is ridiculously powerful, I used it after seeing the deprecation notes for TestClient, and then used this cheatsheet (plus other instances where it is used in the code) to make this test code.

andybalaam · 2023-05-24T10:49:30Z

Focussing on stuck unreads, so not finding time for this, but I haven't forgotten 💚

andybalaam · 2023-06-05T08:23:54Z

Thank you!

* update mutual rooms support * clarify docs and switch eslint comment with todo * please the holy linter * change query variable names around * add mock tests and fix issue * ye holy linter

…ate (#3424) * send expected peer connections to posthog. (based on roomState event) * add tests * change GroupCallStats initialized * prettier * more test and catch for promise * seperate the participant logic in a summary extend function Signed-off-by: Timo K <toger5@hotmail.de> * remove unused Signed-off-by: Timo K <toger5@hotmail.de> * rename summaryStatsReportGatherer to "Reporter" for the summary stats there is only one instance because there is only one summary. Since we dont have a list of gatherers it this class only reports. Hence we rename it to be a reporter. Signed-off-by: Timo K <toger5@hotmail.de> * review Signed-off-by: Timo K <toger5@hotmail.de> * Update src/webrtc/stats/groupCallStats.ts Co-authored-by: Robin <robin@robin.town> * revert rename Signed-off-by: Timo K <toger5@hotmail.de> * Update all non-major dependencies (#3433) * Update all non-major dependencies * Remove name wrap-ansi-cjs * Remove name string-width-cjs --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Telatynski <7t3chguy@gmail.com> * Update definitelyTyped (#3430) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Telatynski <7t3chguy@gmail.com> * Export FALLBACK_ICE_SERVER (#3429) * Add an integration test for verification (#3436) * Move existing crypto integ tests into a subdirectory * Factor out some common bits from `crypto.spec.ts` * Integration test for device verification * Ignore generated file in prettier * Always show a summary after Jest tests (#3440) ... because it is otherwise impossible to see what failed. * Use correct /v3 prefix for /refresh (#3016) * Add tests to ensure /v3/refresh is called + automatic /v1 retry * Request /refresh with v3 prefix, and quietly fall back to v1 * Add tests checking re-raising errors * Update spec/unit/login.spec.ts * Update comment Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> --------- Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> * Update Mutual Rooms (MSC2666) support (#3381) * update mutual rooms support * clarify docs and switch eslint comment with todo * please the holy linter * change query variable names around * add mock tests and fix issue * ye holy linter * GHA: build and cypress-test a copy of element-web after each push (#3412) * Build a copy of element-web after each push * Run cypress after each build of element-web * Fix downstream-artifacts build (#3443) * Fix downstream-artifacts build * Update cypress.yml * Fix edge cases around 2nd order relations and threads (#3437) * Fix tests oversimplifying threads fixtures * Check for unsigned thread_id in MatrixEvent::threadRootId * Fix threads order being racy * Make Sonar happier * Iterate * Make sliding sync linearize processing of sync requests (#3442) * Make sliding sync linearize processing of sync requests * Iterate * Iterate * Iterate * Iterate * Disable downstream artifacts build for develop branch (#3444) * Export thread-related types from SDK (#3447) * Export thread-related types from SDK * address PR feedback * Integration test for QR code verification (#3439) * Integration test for QR code verification Followup to #3436: another integration test, this time using the QR code flow * Use Object.defineProperty, and restore afterwards Apparently global.crypto exists in some environments * apply ts-ignore * remove stray comment * Update spec/integ/crypto/verification.spec.ts * Add `getShowSasCallbacks`, `getShowQrCodeCallbacks` to VerifierBase (#3422) * Add `getShowSasCallbacks`, `getShowQrCodeCallbacks` to VerifierBase ... to avoid some type-casting * Integration test for QR code verification Followup to #3436: another integration test, this time using the QR code flow * Rename method ... it turns out not to be used quite as I thought. * tests for new methods * Use Object.defineProperty, and restore afterwards Apparently global.crypto exists in some environments * apply ts-ignore * More test coverage * fix bad merge * Fix changelog_head.py script to be Python 3 compatible * Prepare changelog for v25.2.0-rc.1 * v25.2.0-rc.1 * Fix tsconfig-build.json * Prepare changelog for v25.2.0-rc.2 * v25.2.0-rc.2 * Fix docs deployment * Prepare changelog for v25.2.0-rc.3 * v25.2.0-rc.3 * Prepare changelog for v25.2.0-rc.4 * v25.2.0-rc.4 * [Backport staging] Attempt a potential workaround for stuck notifs (#3387) Co-authored-by: Andy Balaam <andy.balaam@matrix.org> * Prepare changelog for v25.2.0-rc.5 * v25.2.0-rc.5 * [Backport staging] Fix mark as unread button (#3401) Co-authored-by: Michael Weimann <michaelw@matrix.org> * Prepare changelog for v26.0.0-rc.1 * v26.0.0-rc.1 * Prepare changelog for v26.0.0 * v26.0.0 * Resetting package fields for development * use cli.canSupport to determine intentional mentions support (#3445) * use cli.canSupport to determine intentional mentions support * more specific comment * Update src/client.ts Co-authored-by: Michael Telatynski <7t3chguy@gmail.com> --------- Co-authored-by: Michael Telatynski <7t3chguy@gmail.com> * git fixup Signed-off-by: Timo K <toger5@hotmail.de> * import updates Signed-off-by: Timo K <toger5@hotmail.de> * dont revert enricos change Signed-off-by: Timo K <toger5@hotmail.de> * temp rename for lowercase * lowercase --------- Signed-off-by: Timo K <toger5@hotmail.de> Co-authored-by: Robin <robin@robin.town> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Telatynski <7t3chguy@gmail.com> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Co-authored-by: David Lee <david@david-lee.net> Co-authored-by: Jonathan de Jong <jonathan@automatia.nl> Co-authored-by: Stanislav Demydiuk <stas-demydiuk@users.noreply.github.com> Co-authored-by: ElementRobot <releases@riot.im> Co-authored-by: Andy Balaam <andy.balaam@matrix.org> Co-authored-by: Michael Weimann <michaelw@matrix.org> Co-authored-by: Kerry <kerrya@element.io>

ShadowJonathan added 3 commits May 18, 2023 13:57

update mutual rooms support

380673f

clarify docs and switch eslint comment with todo

cdc4ab9

please the holy linter

6f5ed5a

ShadowJonathan requested a review from a team as a code owner May 18, 2023 12:07

ShadowJonathan requested review from andybalaam and artcodespace May 18, 2023 12:07

ShadowJonathan mentioned this pull request May 18, 2023

MSC2666: Get rooms in common with another user matrix-org/matrix-spec-proposals#2666

Open

github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Tasks for the team like planning labels May 18, 2023

github-actions bot deployed to PR Documentation Preview May 18, 2023 12:10 View deployment

andybalaam requested changes May 18, 2023

View reviewed changes

src/client.ts Outdated Show resolved Hide resolved

ShadowJonathan added 3 commits May 19, 2023 11:16

change query variable names around

5a01263

add mock tests and fix issue

4567e73

ye holy linter

a75af5b

github-actions bot deployed to PR Documentation Preview May 19, 2023 10:20 View deployment

ShadowJonathan requested a review from andybalaam May 19, 2023 10:25

andybalaam approved these changes Jun 5, 2023

View reviewed changes

andybalaam added this pull request to the merge queue Jun 5, 2023

Merged via the queue into matrix-org:develop with commit 1a5af9d Jun 5, 2023

ShadowJonathan deleted the update-mutual-rooms branch June 5, 2023 09:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Mutual Rooms (MSC2666) support #3381

Update Mutual Rooms (MSC2666) support #3381

ShadowJonathan commented May 18, 2023 •

edited

Loading

andybalaam commented May 18, 2023

ShadowJonathan commented May 18, 2023

andybalaam left a comment

ShadowJonathan commented May 19, 2023

andybalaam commented May 24, 2023

andybalaam commented Jun 5, 2023

Update Mutual Rooms (MSC2666) support #3381

Update Mutual Rooms (MSC2666) support #3381

Conversation

ShadowJonathan commented May 18, 2023 • edited Loading

Checklist

andybalaam commented May 18, 2023

ShadowJonathan commented May 18, 2023

andybalaam left a comment

Choose a reason for hiding this comment

ShadowJonathan commented May 19, 2023

andybalaam commented May 24, 2023

andybalaam commented Jun 5, 2023

ShadowJonathan commented May 18, 2023 •

edited

Loading