Rewrite receipt-handling code #3901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
force-pushed
the
andybalaam/rewrite-receipts2
branch
from
300be77
to
ee99b1a
Compare
dbkr
approved these changes
Nov 27, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
andybalaam
added a commit
that referenced
this pull request
Nov 28, 2023
This reverts commit c49a527.
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-web#24392
Needed for matrix-org/matrix-react-sdk#11903
Re-write hasUserReadEvent to store all the information at the Room level. Because we must always consider unthreaded receipts globally, it doesn't make sense to answer this question at the Thread level.
We leave the old code for now, because it does other jobs, but soon, we will delete the old storage of receipts.
Here's what your changelog entry will look like:
🐛 Bug Fixes