Clean up code for handling decryption failures #4126
Conversation
This is unreachable with `crypto` unset. That's enforced by the types. If you call it with an unset `crypto`, you deserve a TypeError.
This should be more reliable, and more efficient, than checking the message type.
| @@ -211,12 +214,11 @@ export class DecryptionError extends Error { | |||
| public readonly detailedString: string; | |||
|
|
|||
| public constructor( | |||
| public readonly code: string, | |||
There was a problem hiding this comment.
Well first of all, this class (and indeed the whole file) is supposed to be internal, so anyone using it can keep both halves when it breaks.
In any case: It would only be a breaking change for things constructing a DecryptionError: anything reading code once it is created will implicitly cast the DecryptionFailureCode to a string. And I've not been able to find any code constructing a DecryptionError outside the js-sdk.
|
However, it turns out the removal of |
|
Once matrix-org/matrix-react-sdk#12364 lands, this should be good to go too. |
|
going to override the coverage gate on this |
Various improvements, including:
enumfor decryption failure reasonsEventReview commit-by-commit.