Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Playwright: Fix assertUnreadLessThan and assertUnreadGreaterThan #12012

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Dec 7, 2023

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

toBeGreaterThan and toLesserThan are non retry assertion, so we should use expect.poll to add a retry mechanism.

Part of element-hq/element-web#25449


This change is marked as an internal change (Task), so will not be included in the changelog.

@florianduros florianduros added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Dec 7, 2023
@florianduros florianduros added this pull request to the merge queue Dec 7, 2023
Merged via the queue into develop with commit 845838b Dec 7, 2023
24 checks passed
@florianduros florianduros deleted the florianduros/unread/fix-non-retry-expect branch December 7, 2023 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants