Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Playwright: Fix assertUnreadLessThan and assertUnreadGreaterThan #12012

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Playwright: Fix assertUnreadLessThan and assertUnreadGreaterThan #12012

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ed9e13
Fix `assertUnreadLessThan` and `assertUnreadGreaterThan`
florianduros Dec 7, 2023
eb86152
Merge branch 'develop' into florianduros/unread/fix-non-retry-expect
florianduros Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions playwright/e2e/read-receipts/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,13 @@ class Helpers {
*/
async assertUnreadLessThan(room: string | { name: string }, lessThan: number) {
const tile = this.getRoomListTile(room);
expect(parseInt(await tile.locator(".mx_NotificationBadge_count").textContent(), 10)).toBeLessThan(lessThan);
// https://playwright.dev/docs/test-assertions#expectpoll
// .toBeLessThan doesn't have a retry mechanism, so we use .poll
await expect
.poll(async () => {
return parseInt(await tile.locator(".mx_NotificationBadge_count").textContent(), 10);
})
.toBeLessThan(lessThan);
}

/**
Expand All @@ -482,9 +488,13 @@ class Helpers {
*/
async assertUnreadGreaterThan(room: string | { name: string }, greaterThan: number) {
const tile = this.getRoomListTile(room);
expect(parseInt(await tile.locator(".mx_NotificationBadge_count").textContent(), 10)).toBeGreaterThan(
greaterThan,
);
// https://playwright.dev/docs/test-assertions#expectpoll
// .toBeGreaterThan doesn't have a retry mechanism, so we use .poll
await expect
.poll(async () => {
return parseInt(await tile.locator(".mx_NotificationBadge_count").textContent(), 10);
})
.toBeGreaterThan(greaterThan);
}

/**
Expand Down
Loading